Minimal approach to making Deinterleave correct for Reinterpret - #6923
Closed
abadams wants to merge 1 commit into
Closed
Minimal approach to making Deinterleave correct for Reinterpret#6923abadams wants to merge 1 commit into
abadams wants to merge 1 commit into
Conversation
abadams
marked this pull request as draft
August 5, 2022 19:31
abadams
marked this pull request as ready for review
August 6, 2022 00:36
rootjalex
approved these changes
Aug 11, 2022
rootjalex
left a comment
rootjalex
left a comment
Member
There was a problem hiding this comment.
Lgtm in principle, but would it be possible to add a test for the specific case of calling deinterleave on a reinterpret where to.bits() != from.bits()?
Member
Author
|
Good point. Will do. |
Member
Author
|
Actually I don't think I can trigger that without #6928 , and without this, that PR is slightly busted. I'll just combine the two. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minimal baseline for the purpose of discussion and comparison with #6887