Skip to content

Minimal approach to making Deinterleave correct for Reinterpret #6923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abadams wants to merge 1 commit into from
Closed

Minimal approach to making Deinterleave correct for Reinterpret #6923

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions src/Deinterleave.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,16 @@ class Deinterleaver : public IRGraphMutator {
return expr;
}

Expr give_up_and_shuffle(const Expr &e) {
// Uh-oh, we don't know how to deinterleave this vector expression
// Make llvm do it
std::vector<int> indices;
for (int i = 0; i < new_lanes; i++) {
indices.push_back(starting_lane + lane_stride * i);
}
return Shuffle::make({e}, indices);
}

Expr visit(const Variable *op) override {
if (op->type.is_scalar()) {
return op;
Expand Down Expand Up @@ -302,13 +312,7 @@ class Deinterleaver : public IRGraphMutator {
lane_stride == 3) {
return Variable::make(t, op->name + ".lanes_2_of_3", op->image, op->param, op->reduction_domain);
} else {
// Uh-oh, we don't know how to deinterleave this vector expression
// Make llvm do it
std::vector<int> indices;
for (int i = 0; i < new_lanes; i++) {
indices.push_back(starting_lane + lane_stride * i);
}
return Shuffle::make({op}, indices);
return give_up_and_shuffle(op);
}
}
}
Expand All @@ -325,6 +329,8 @@ class Deinterleaver : public IRGraphMutator {
Expr visit(const Reinterpret *op) override {
if (op->type.is_scalar()) {
return op;
} else if (op->type.bits() != op->value.type().bits()) {
return give_up_and_shuffle(op);
} else {
Type t = op->type.with_lanes(new_lanes);
return Reinterpret::make(t, mutate(op->value));
Expand Down