Skip to content

feat: create mock junit annotations#104

Merged
nathanklick merged 16 commits intomainfrom
00102-Mock-Core-Annotations
Aug 13, 2023
Merged

feat: create mock junit annotations#104
nathanklick merged 16 commits intomainfrom
00102-Mock-Core-Annotations

Conversation

@nathanklick
Copy link
Copy Markdown
Member

@nathanklick nathanklick commented Jun 14, 2023 •
edited
Loading

Description

This pull request changes the following:

  • Adds an initial draft of the end-user facing JUnit annotations.
  • Adds javadoc to the new annotations and some existing classes where necessary.
  • All items added are non-functional mocks and does not impact any existing functional code.

Related Issues

@nathanklick nathanklick self-assigned this Jun 14, 2023
@nathanklick nathanklick added the New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. label Jun 14, 2023
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 14, 2023 •
edited
Loading

Unit Test Results

16 files  ±0  16 suites  ±0   31s ⏱️ -1s
85 tests ±0  82 ✔️ ±0  3 💤 ±0  0 ❌ ±0 
86 runs  ±0  83 ✔️ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit 83b2de0. ± Comparison against base commit cd0e331.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 14, 2023 •
edited
Loading

Codecov Report

Merging #104 (59b630f) into main (a5bfe5a) will decrease coverage by 0.48%.
Report is 4 commits behind head on main.
The diff coverage is 0.00%.

❗ Current head 59b630f differs from pull request most recent head 83b2de0. Consider uploading reports for the commit 83b2de0 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #104      +/-   ##
============================================
- Coverage     62.23%   61.76%   -0.48%     
  Complexity      254      254              
============================================
  Files            47       48       +1     
  Lines          1046     1054       +8     
  Branches        130      130              
============================================
  Hits            651      651              
- Misses          344      352       +8     
  Partials         51       51
Files Changed Coverage Δ
.../hedera/fullstack/base/api/units/StorageUnits.java 0.00% <0.00%> (ø)

Impacted file tree graph

@nathanklick nathanklick marked this pull request as ready for review June 16, 2023 22:00
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@nathanklick nathanklick force-pushed the 00102-Mock-Core-Annotations branch 4 times, most recently from ba7fb34 to 520cca3 Compare August 11, 2023 15:45
leninmehedy
leninmehedy approved these changes Aug 13, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@leninmehedy leninmehedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty Cool. Thanks.

@nathanklick
chore: initial mock pass on annotations
6236e69 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: add parameterized test support
f6b009b 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: relocate annotations to core package
2da0a9d 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: annotation mock madness
f5010d7 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: add minor in progress changes
2667524 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: completed mock of the SSTT basic test
d95bf9f 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: mocks in progress
47e2096 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: rename package
0e6e2ef 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: formatting and javadocs
279a694 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: code formatting
eb6afe5 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: work in progress
d7c0ee1 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: work in progress
2b3a535 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: ensure branch compiles
74ec681 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: update javadoc
2e13be2 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: updated javadoc
b66c7da 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick
chore: update annotations
83b2de0 
Signed-off-by: Nathan Klick <nathan@swirldslabs.com>
@nathanklick nathanklick force-pushed the 00102-Mock-Core-Annotations branch from d9f4654 to 83b2de0 Compare August 13, 2023 21:03
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@nathanklick nathanklick merged commit 752b2df into main Aug 13, 2023
@nathanklick nathanklick deleted the 00102-Mock-Core-Annotations branch August 13, 2023 21:15
swirlds-automation added a commit that referenced this pull request Aug 25, 2023
@swirlds-automation
chore(release): 0.7.0 [skip ci]
dc5d8fc 
## [0.7.0](v0.6.0...v0.7.0) (2023-08-25)

### Features

* add minio tenant helm chart conditionally ([#239](#239)) ([99b2527](99b2527))
* add service definitions for HAProxy and Envoy with support for both ClusterIP and LoadBalancer configurations ([#268](#268)) ([8563e16](8563e16))
* add support for rendering an optional PrometheusOperator ServiceMonitor resource definition ([#271](#271)) ([84cbbed](84cbbed))
* create mock junit annotations ([#104](#104)) ([752b2df](752b2df))
* enable helm template substitutions on Open Collector config map ([#274](#274)) ([1fa684b](1fa684b))
* mirror node as a conditional subchart ([#272](#272)) ([8842aa0](8842aa0))

### Bug Fixes

* update envoy cluster name in the config ([#276](#276)) ([5fef59f](5fef59f))
@swirlds-automation
Copy link
Copy Markdown
Contributor

swirlds-automation commented Aug 25, 2023

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leninmehedy leninmehedy leninmehedy approved these changes

@jeromy-cannon jeromy-cannon Awaiting requested review from jeromy-cannon

@deepak-swirlds deepak-swirlds Awaiting requested review from deepak-swirlds

Assignees

@nathanklick nathanklick

Labels

New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

UTMCA: Create initial draft of the core annotation mocks

3 participants

@nathanklick @swirlds-automation @leninmehedy