Skip to content

feat: add support for rendering an optional PrometheusOperator ServiceMonitor resource definition#271

Merged
leninmehedy merged 21 commits intomainfrom
227-prometheus-servicemonitor
Aug 22, 2023
Merged

feat: add support for rendering an optional PrometheusOperator ServiceMonitor resource definition#271
leninmehedy merged 21 commits intomainfrom
227-prometheus-servicemonitor

Conversation

@leninmehedy
Copy link
Copy Markdown
Member

@leninmehedy leninmehedy commented Aug 14, 2023

Description

This pull request changes the following:

  • Adds support for deploying prometheus service monitor for all network nodes
  • Adds helper scripts to deploy prometheus locally
  • Update CI/CD pipeline to deploy prometheus-operator
  • Update dev/Makefile to install prometheus-operator (if it does not exist) before deploying the network locally

Notes:

  • It was tested using prometheus operator: v0.67.1

Related Issues

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
…ra-network

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
This is because OTel collector ports can be configured by the user

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@leninmehedy leninmehedy marked this pull request as ready for review August 14, 2023 01:48
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
…nstalled already

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 14, 2023

Unit Test Results

16 files  ±0  16 suites  ±0   35s ⏱️ +5s
85 tests ±0  82 ✔️ ±0  3 💤 ±0  0 ±0 
86 runs  ±0  83 ✔️ ±0  3 💤 ±0  0 ±0 

Results for commit 5e57f43. ± Comparison against base commit 99b2527.

♻️ This comment has been updated with latest results.

leninmehedy and others added 7 commits August 22, 2023 04:25
Co-authored-by: Nathan Klick <nathan@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>

# Conflicts:
#	dev/Makefile
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
…eployment

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@leninmehedy leninmehedy merged commit 84cbbed into main Aug 22, 2023
@leninmehedy leninmehedy deleted the 227-prometheus-servicemonitor branch August 22, 2023 05:04
leninmehedy added a commit that referenced this pull request Aug 25, 2023
…eMonitor resource definition (#271)

Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
Co-authored-by: Nathan Klick <nathan@swirldslabs.com>
swirlds-automation added a commit that referenced this pull request Aug 25, 2023
## [0.7.0](v0.6.0...v0.7.0) (2023-08-25)

### Features

* add minio tenant helm chart conditionally ([#239](#239)) ([99b2527](99b2527))
* add service definitions for HAProxy and Envoy with support for both ClusterIP and LoadBalancer configurations ([#268](#268)) ([8563e16](8563e16))
* add support for rendering an optional PrometheusOperator ServiceMonitor resource definition ([#271](#271)) ([84cbbed](84cbbed))
* create mock junit annotations ([#104](#104)) ([752b2df](752b2df))
* enable helm template substitutions on Open Collector config map ([#274](#274)) ([1fa684b](1fa684b))
* mirror node as a conditional subchart ([#272](#272)) ([8842aa0](8842aa0))

### Bug Fixes

* update envoy cluster name in the config ([#276](#276)) ([5fef59f](5fef59f))
@swirlds-automation
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chart[Network Node]: Add support for rendering an optional PrometheusOperator ServiceMonitor resource definition

3 participants