Skip to content

totp: Enforce otp code length#31246

Merged
mpalmi merged 3 commits intomainfrom
fix/otp-code-length
Jul 11, 2025
Merged

totp: Enforce otp code length#31246
mpalmi merged 3 commits intomainfrom
fix/otp-code-length

Conversation

@mpalmi
Copy link
Contributor

@mpalmi mpalmi commented Jul 10, 2025

Description

This PR introduces a code length check to ensure that the code length matches key length.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@mpalmi mpalmi requested a review from mickael-hc July 10, 2025 18:41
@mpalmi mpalmi requested a review from a team as a code owner July 10, 2025 18:41
@mpalmi mpalmi requested a review from HamzaShili65 July 10, 2025 18:41
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 10, 2025
@github-actions
Copy link

github-actions bot commented Jul 10, 2025

CI Results:
All Go tests succeeded! ✅

@github-actions
Copy link

github-actions bot commented Jul 10, 2025

Build Results:
All builds succeeded! ✅

mickael-hc
mickael-hc previously approved these changes Jul 11, 2025
@mpalmi mpalmi requested review from bosouza and mickael-hc July 11, 2025 19:14
Copy link
Contributor

@bosouza bosouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mpalmi mpalmi enabled auto-merge (squash) July 11, 2025 19:19
@mpalmi mpalmi merged commit b2c814d into main Jul 11, 2025
86 checks passed
@mpalmi mpalmi deleted the fix/otp-code-length branch July 11, 2025 19:32
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
Co-authored-by: mickael e <mickael@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants