Skip to content

totp: Enforce otp code length #31246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpalmi merged 3 commits into from
Jul 11, 2025
Merged

totp: Enforce otp code length #31246

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbaf247
secrets/totp: trim space before processing request
mickael-hc Jul 4, 2025
c5e2464
Merge branch 'main' into fix/otp-code-length
mpalmi Jul 11, 2025
abeee16
Update builtin/logical/totp/path_code.go
mpalmi Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions builtin/logical/totp/backend_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,8 @@ func TestBackend_keyCrudDefaultValues(t *testing.T) {
testAccStepReadKey(t, "test", expected),
testAccStepValidateCode(t, "test", code, true, false),
// Next step should fail because it should be in the used cache
testAccStepValidateCode(t, "test", code+" ", false, true),
testAccStepValidateCode(t, "test", " "+code, false, true),
testAccStepValidateCode(t, "test", code, false, true),
testAccStepValidateCode(t, "test", invalidCode, false, false),
testAccStepDeleteKey(t, "test"),
Expand Down
5 changes: 3 additions & 2 deletions builtin/logical/totp/path_code.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package totp
import (
"context"
"fmt"
"strings"
"time"

"github.com/hashicorp/vault/sdk/framework"
Expand Down Expand Up @@ -85,8 +86,8 @@ func (b *backend) pathReadCode(ctx context.Context, req *logical.Request, data *
}

func (b *backend) pathValidateCode(ctx context.Context, req *logical.Request, data *framework.FieldData) (*logical.Response, error) {
name := data.Get("name").(string)
code := data.Get("code").(string)
name := strings.TrimSpace(data.Get("name").(string))
code := strings.TrimSpace(data.Get("code").(string))

// Enforce input value requirements
if code == "" {
Expand Down
Loading