I'd set MaxWait to a small value for local testing, but the default i…#9478
Merged
I'd set MaxWait to a small value for local testing, but the default i…#9478
Conversation
…s probably better for CI.
Collaborator
Author
|
Example failure this should address: https://circleci.hashicorp.engineering/gh/hashicorp/vault-enterprise/40284#tests/containers/1 |
builtin/logical/ssh/backend_test.go
Outdated
|
|
||
| // exponential backoff-retry | ||
| pool.MaxWait = 10 * time.Second | ||
| //pool.MaxWait = 10 * time.Second |
Contributor
There was a problem hiding this comment.
why leave this commented out and not just remove it entirely?
Collaborator
Author
There was a problem hiding this comment.
Eh, when doing local development the default maxwait is annoyingly high, and I figured I'd save someone from having to lookup how to fix it. Probably wrong-headed, I'll remove it.
Contributor
There was a problem hiding this comment.
Gotcha, maybe just leave a helpful comment instead?
alexanderbez
approved these changes
Jul 14, 2020
pull bot
pushed a commit
to mayocream/vault
that referenced
this pull request
Sep 22, 2025
…rp#9478) (hashicorp#9524) * make allowed and denied_parameters compare lists * change name of env var * add changelog * linter fixes and unnecessary code removal Co-authored-by: Bruno Oliveira de Souza <bruno.souza@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s probably better for CI.