Closed
Conversation
andaley
force-pushed
the
ui/update-datefns
branch
from
563f604 to
75a14e0
Compare
Contributor
Author
|
@chelshaw @Monkeychip i'm closing this PR for now since it wasn't needed to fix the transit bug from last week and i don't see a huge need to update datefns just yet. if you encounter a reason to during the Ember upgrade you can re-open it, rebase and merge. :) |
Contributor
|
Reopening this so we can take advantage of RFC3339 formatting (available in >=2.8) which is the format used for Pricing Metrics api parameters. |
…dling of non-ISO date strings
chelshaw
force-pushed
the
ui/update-datefns
branch
from
ab2ece6 to
1eaa1dd
Compare
Contributor
|
@noelledaley @chelshaw is this PR still relevant? |
Contributor
|
No longer relevant, updated in #10848 😄 |
pull bot
pushed a commit
to mayocream/vault
that referenced
this pull request
Sep 22, 2025
…rp#9478) (hashicorp#9524) * make allowed and denied_parameters compare lists * change name of env var * add changelog * linter fixes and unnecessary code removal Co-authored-by: Bruno Oliveira de Souza <bruno.souza@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update date-fns
Update date-fns to 2.0.0 which requires us update all of our date-related helpers. The most notable change we had to account for is that all of the date-fns functions no longer accept strings as arguments. You'll notice we also had to switch some of the formatting arguments from
YYYYtoyyyyas a result. See the full list of breaking changes when upgrading to date-fns 2.0.0 here.Testing
This PR requires a considerable QA as it changes the behavior of our
date-from-nowanddate-formathelpers. We now return an empty string and console log an error if the formatting doesn't work, so there's a chance some dates may be missing in the UI.Navigate to the various pages of the UI where
date-formatordate-from-nowis used, such as the replication secondaries add modal which displays the expiration date. These pages should still display the date as expected.Here's an example of the replication secondaries add modal:
