Refactor and future proof Show Options instance#526
Merged
Conversation
Collaborator
|
LGTM |
Collaborator
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a regression test for this in 88c244e.
Unfortunately pattern matching with record syntax does not* warn about left-overs which means adding fields to
Optionswould silently make the show instance outdated. I changed it to a normal constructor match to prevent this. The downside is that the field names get lost but I think it's worthwhile.I also don't like
RecordWildCardssince it causes shadowing. Shadowing is a warning under-Wallbut not when combined withRecordWildCards!