Option to encode single-constructor types as tagged sums#522
Conversation
|
Github showed the already merged PR's in the history so i force pushed a rebase. |
|
Thanks again, This looks good as well! Unavoidably this is a breaking change due to the I'll cut a release with the other PR's tomorrow and then merge this. |
|
Looks like i also confused myself and travis by doing "git push origin Lysxia/feature-474" so don't mind the test failure! |
|
I noticed that the new field needs to be added to the |
|
#526 was merged so this can be rebased. |
5cb6d6d to
6674f53
Compare
|
Same here, I didn't get notified of the recent changes. Thanks a lot for this! |
|
Okay! You're welcome! Actually this patch may lead to some serious regressions because I've introduced an actual loop in the generic implementation. We can probably avoid it by tracking the new option at the type level, as a parameter of the |
|
This is now just two simple overlapping instances instead of the previous recursive mess. Ready to merge. |
|
Great stuff! |
As suggested in #206 and possibly #473