Fix Generic encoding of records with single Maybe field#532
Merged
Conversation
7842a26 to
af6adaf
Compare
Collaborator
|
Looks great, thanks! To be safe I think I'll include this in 1.2.0.0. Do you have a preferred order for merging your PR's? |
Collaborator
Author
Collaborator
|
This has some merge conflicts now |
Collaborator
Author
|
Rebased. This now just adds the regression test case. |
Collaborator
|
Great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
We have:
Yet:
That is, if the field is
Nothing, then the record is not being unwrapped andomitNothingFieldsapplies instead, producing an empty object.