Prevent possible invalid memory accesses by sprintf#459
Merged
ligenxxxx merged 3 commits intohd-zero:mainfrom Nov 21, 2024
Merged
Prevent possible invalid memory accesses by sprintf#459ligenxxxx merged 3 commits intohd-zero:mainfrom
ligenxxxx merged 3 commits intohd-zero:mainfrom
Conversation
Contributor
|
I would also update the related code to use snprintf to prevent buffer overflows. sprintf should not be used in any code base. |
Contributor
Author
|
I agree about using |
Member
|
I use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update (2024-11-19)
Per the discussion below, I replaced all calls to
sprintfwith respective ones tosnprintfthat only writes as many chars as fit the target.Original description
I compile the emulator locally with gcc-14 and it outputs warnings for some of the buffers used to hold numerical values (see example screenshot below).
These changes should not do any harm but use more of the stack memory while calling the changed methods, but it should be ok imho.