Skip to content

Prevent possible invalid memory accesses by sprintf #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ligenxxxx merged 3 commits into from
Nov 21, 2024
Merged

Prevent possible invalid memory accesses by sprintf #459

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a5a7a34
Resize buffers to allow maximum string size
Master92 Nov 18, 2024
327a045
Fix missing sprintf target
Master92 Nov 19, 2024
26e1d41
Replace occurrences of sprintf with snprintf where possible
Master92 Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix missing sprintf target
  • Loading branch information
@Master92
Master92 committed Nov 19, 2024
commit 327a045b198b8b27657ed5073ff3a256e97c01a2
2 changes: 1 addition & 1 deletion src/ui/page_version.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ static void flash_goggle() {
sprintf(buf, "$FFFF00 %s.#", _lang("No firmware found"));
lv_label_set_text(btn_goggle, buf);
} else if (ret == 3) {
sprintf("#FFFF00 %s. %s.#", _lang("Multiple versions been found"), _lang("Keep only one"));
sprintf(buf, "#FFFF00 %s. %s.#", _lang("Multiple versions been found"), _lang("Keep only one"));
lv_label_set_text(btn_goggle, buf);
} else {
sprintf(buf, "#FF0000 %s#", _lang("FAILED"));
Expand Down