Skip to content

refactor(box): destructure#3940

Merged
SukkaW merged 1 commit into
hexojs:masterfrom
curbengh:box-destructure
Dec 14, 2019
Merged

refactor(box): destructure#3940
SukkaW merged 1 commit into
hexojs:masterfrom
curbengh:box-destructure

Conversation

@curbengh

@curbengh curbengh commented Dec 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does it do?

How to test

git clone -b box-destructure https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@coveralls

coveralls commented Dec 13, 2019

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.0008%) to 97.139% when pulling 9d12781 on curbengh:box-destructure into e4a5292 on hexojs:master.

1 similar comment
@coveralls

coveralls commented Dec 13, 2019

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.0008%) to 97.139% when pulling 9d12781 on curbengh:box-destructure into e4a5292 on hexojs:master.

SukkaW
SukkaW approved these changes Dec 14, 2019
View reviewed changes

@SukkaW SukkaW left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SukkaW SukkaW merged commit 2c50d3b into hexojs:master Dec 14, 2019
@SukkaW SukkaW mentioned this pull request Dec 19, 2019
Merged
2 tasks
thom4parisot referenced this pull request in thom4parisot/hexo Jan 17, 2020
@curbengh
refactor(box): destructure (#3940)
93ba4d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SukkaW SukkaW SukkaW approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@curbengh @coveralls @SukkaW