refactor: destructure modules#3992
Merged
Merged
Conversation
SukkaW
force-pushed
the
style-destructure-modules
branch
from
014f19c to
4276c3d
Compare
SukkaW
force-pushed
the
style-destructure-modules
branch
from
4276c3d to
7c9c8e5
Compare
SukkaW
force-pushed
the
style-destructure-modules
branch
from
7c9c8e5 to
a58f39c
Compare
curbengh
reviewed
Dec 19, 2019
| const doc = Page.findOne({source: path}); | ||
| const { config } = ctx; | ||
| const { timezone, use_date_for_updated } = config; | ||
| const { timezone: timezoneCfg, use_date_for_updated } = config; |
curbengh
approved these changes
Dec 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Continuation of #3324 #3940 & #3953
How to test
Screenshots
Pull request tasks