feat: contribute to Holdex repos using a structured Claude Code skill#100
Open
zolotokrylin wants to merge 3 commits intomainfrom
Open
feat: contribute to Holdex repos using a structured Claude Code skill#100zolotokrylin wants to merge 3 commits intomainfrom
zolotokrylin wants to merge 3 commits intomainfrom
Conversation
Contributor
WalkthroughAdded a new Claude command file defining Holdex contribution standards for GitHub issues and PRs, including required formatting for issue titles (job story format) and PR titles (Conventional Commits style), plus a defined PR lifecycle. Updated README with setup instructions for the new command. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Time Submission Status
You can submit time with the command. Example: See available commands to help comply with our Guidelines. |
Member
Author
|
@holdex pr submit-time 1h |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
README.md (1)
30-32: Use an idempotent symlink command for repeat setup runs.
ln -sfails if~/.claude/commandsalready exists. Use a safer one-liner so contributors can re-run setup without manual cleanup.Suggested doc update
- ln -s /path/to/holdex/developers/.claude/commands ~/.claude/commands + mkdir -p ~/.claude && ln -sfn /path/to/holdex/developers/.claude/commands ~/.claude/commands🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` around lines 30 - 32, Replace the fragile "ln -s /path/to/holdex/developers/.claude/commands ~/.claude/commands" example with an idempotent symlink one-liner: ensure the target directory (~/.claude) is created if missing and create or replace the symlink to /path/to/holdex/developers/.claude/commands using the force/replace options so repeated setup runs don't fail; update the README example line that currently shows "ln -s /path/to/holdex/developers/.claude/commands ~/.claude/commands" accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.claude/commands/holdex-contributing.md:
- Around line 6-8: Add a level-1 heading immediately after the existing front
matter block in the holdex-contributing markdown (e.g., insert "#
holdex-contributing" right after the front matter delimiter) to satisfy
markdownlint MD041; ensure the heading is the first content following the front
matter and does not alter the existing contributing text that follows.
- Around line 16-20: The markdown code block contains a single long line that
violates MD013 (80-char line length); split that long URL line into two wrapped
lines within the code block so it stays a valid list item and under 80
characters (e.g., break the URL after a logical separator or split the list item
into the dash line and the URL on the next indented line). Update the example
list item in the code block under the guidance section so the long line is
wrapped to satisfy MD013 while preserving the bullet (`-`) and the referenced
URL text.
- Around line 11-14: Update the “Good” example to include the required prefix so
it matches the rule "Name: `Problem: [statement]`" — change the good example
from `employees can't safely handle fund disbursements` to `Problem: employees
can't safely handle fund disbursements` so the guidance is consistent; ensure
the text in the doc that currently shows the Good example is replaced with the
prefixed version.
---
Nitpick comments:
In `@README.md`:
- Around line 30-32: Replace the fragile "ln -s
/path/to/holdex/developers/.claude/commands ~/.claude/commands" example with an
idempotent symlink one-liner: ensure the target directory (~/.claude) is created
if missing and create or replace the symlink to
/path/to/holdex/developers/.claude/commands using the force/replace options so
repeated setup runs don't fail; update the README example line that currently
shows "ln -s /path/to/holdex/developers/.claude/commands ~/.claude/commands"
accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d6729cd2-3382-47d0-8135-af2f0104429e
📒 Files selected for processing (2)
.claude/commands/holdex-contributing.mdREADME.md
Comment on lines
+6
to
+8
| All PRs and issues must follow the | ||
| [Holdex Contributing Guidelines](https://github.com/holdex/developers/blob/main/docs/CONTRIBUTING.md). | ||
|
|
Contributor
There was a problem hiding this comment.
Add a level-1 heading after front matter.
Markdownlint MD041 is valid here. Add a top-level heading (for example # holdex-contributing) right after the front matter block.
🧰 Tools
🪛 GitHub Check: checks
[warning] 6-6: MD041
First line in file should be a level 1 heading
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.claude/commands/holdex-contributing.md around lines 6 - 8, Add a level-1
heading immediately after the existing front matter block in the
holdex-contributing markdown (e.g., insert "# holdex-contributing" right after
the front matter delimiter) to satisfy markdownlint MD041; ensure the heading is
the first content following the front matter and does not alter the existing
contributing text that follows.
Comment on lines
+11
to
+14
| - Name: `Problem: [statement]` — must be a **job story** describing what a | ||
| specific user **cannot do** (the whole title under 65 characters). | ||
| - Good: `employees can't safely handle fund disbursements` | ||
| - Bad: `fund handling issue` |
Contributor
There was a problem hiding this comment.
Make the “Good” issue example match the required format.
You require Problem: [statement], but the “Good” example omits the Problem: prefix. Update it to avoid contradictory guidance.
Suggested doc update
- - Good: `employees can't safely handle fund disbursements`
+ - Good: `Problem: employees can't safely handle fund disbursements`🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.claude/commands/holdex-contributing.md around lines 11 - 14, Update the
“Good” example to include the required prefix so it matches the rule "Name:
`Problem: [statement]`" — change the good example from `employees can't safely
handle fund disbursements` to `Problem: employees can't safely handle fund
disbursements` so the guidance is consistent; ensure the text in the doc that
currently shows the Good example is replaced with the prefixed version.
Comment on lines
+16
to
+20
| - When referencing other issues or PRs, always use a **list item**, never inline: | ||
|
|
||
| ```md | ||
| - https://github.com/holdex/hr-internal/issues/123 | ||
| ``` |
Contributor
There was a problem hiding this comment.
Wrap the long line to satisfy MD013.
The line in this block exceeds the configured 80-char limit. Split it into two lines to keep lint green.
🧰 Tools
🪛 GitHub Check: checks
[warning] 16-20: MD013
Line length 81 exceeds 80 characters
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.claude/commands/holdex-contributing.md around lines 16 - 20, The markdown
code block contains a single long line that violates MD013 (80-char line
length); split that long URL line into two wrapped lines within the code block
so it stays a valid list item and under 80 characters (e.g., break the URL after
a logical separator or split the list item into the dash line and the URL on the
next indented line). Update the example list item in the code block under the
guidance section so the long line is wrapped to satisfy MD013 while preserving
the bullet (`-`) and the referenced URL text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/commands/holdex-contributing.md— a/holdex-contributingskill for Claude CodeCONTRIBUTING.md(issue naming, PR title format, PR lifecycle) so contributors can invoke it on demand before creating or updating issues and PRsUsage
Run
/holdex-contributingin Claude Code before creating or updating a GitHub issue or PR in any Holdex repository.🤖 Generated with Claude Code
Summary by CodeRabbit