Makefile: remove gold linker, fix indentation.#487
Merged
carrotIndustries merged 1 commit intohorizon-eda:masterfrom Aug 5, 2020
ericonr:gol
Merged
Makefile: remove gold linker, fix indentation.#487carrotIndustries merged 1 commit intohorizon-eda:masterfrom ericonr:gol
carrotIndustries merged 1 commit intohorizon-eda:masterfrom
ericonr:gol
Conversation
Member
The gold linker is about twice as fast as the regular one. Linking horizon-imp takes 10s with the gold linker, 20s with the regular one.
Why not make it the other way round and keep gold the default and add an option to use the non-gold ld? |
Contributor
Author
Sure! Could it be something like and a user can use |
Member
Yes, go ahead. |
Fix indentation. Gold linker isn't available or fully compliant for some architectures, so it makes sense to allow a user to disable it using `make GOLD=`.
Contributor
Author
|
Done! |
carrotIndustries
requested changes
Aug 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gold linker brings little benefit, isn't available or fully compliant
for some architectures, and can have issues with libraries located
outside /usr/lib.
Rust tried enabling it, but had to revert: rust-lang/rust#30913
When packaging Horizon for Void Linux, I had to remove
-fuse-ld=goldfrom the Makefile, since it isn't available for our cross compilation setup.It was enabled some years ago for no reason that I could find.
This way, if someone wants it, it can still be passed on the environment.