Closed
Conversation
| @@ -0,0 +1,6 @@ | |||
| project(cppfront CXX) | |||
There was a problem hiding this comment.
This entire file is UB without cmake_minimium_required at the top
Author
|
Seeing Herb’s answer here, it looks like CMake will be more a problem than a solution for him in this early stage. Closing this PR at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little CMakeLists.txt file that is used by new GitHub action workflows to build cppfront on different platforms. The only one failing right now is in Ubuntu with gcc 9 (it looks like the header file is not available). I can add an extra check for that header file in the CMakeLists.txt, but I think it would be better if it can be detected with a preprocessor macro (so cppfront could be still compiled with CMake).
After this is merged (or some other/modified version of this) I can add the automatic compilation and execution of all regression tests on each pushed commit or PR with cmake/ctest.
I accept the Contributor License Agreement: https://github.com/hsutter/cppfront/blob/fa65d346996ec472e16c61838fbc7a47736d7872/CONTRIBUTING.md#contributor-license-agreement