Added Build System Integration by Eshanatnight · Pull Request #4 · hsutter/cppfront

Eshanatnight · 2022-09-19T04:34:59Z

Added Cmakelists.txt, .clang-format, .clang-tidy and premake5.lua .

Because of this .gitignore file was modified to not include the build directory.
and a .gitattributes file was added

Eshanatnight · 2022-09-19T04:41:05Z

forgot to push premake5.lua when the first comment was made :>

Frityet · 2022-09-20T15:51:50Z

Why premake?

Eshanatnight · 2022-09-20T15:56:30Z

Actually i also wrote a cmakelists.txt but for some reason it got deleted?

And as for why premake, after no specific reason I started using premake instead of cmake because i wanted to learn Lua and i thought the fastest way would be to use it

Eshanatnight · 2022-09-20T17:36:44Z

Just added the Cmakelists file. Found why it was not being tracked by git, .txt files were in the .gitignore

JohelEGP

I find this unsatisfactory because the executable isn't exported. I can only use this by add_subdirectory and not find_package.

CMakelists.txt

Eshanatnight · 2022-09-20T17:40:06Z

Need to find a way to make the tests

I find this unsatisfactory because the executable isn't exported. I can only use this by add_subdirectory and not find_package.

Then would we not need to make the tests in to a "sub-projects" of sorts? Rather than the current way of using .bat files?

JohelEGP · 2022-09-20T17:43:03Z

My comment is not in regard to tests, but to consumers of the cppfront executable.

Eshanatnight · 2022-09-20T17:47:30Z

My comment is not in regard to tests, but to consumers of the cppfront executable.

Oh I understand you meant that the CMakeLists File is unsatisfactory. The executable can easily be copied/moved with a post build command. To a standard location. This should also help in making and running the tests easier, in my opinion.

And I left the Output Dir relative to the build system as the Author & Maintainers might want something Specific

Colliflower · 2022-09-21T04:36:44Z

.gitignore

+/.vs
+/.vscode


Suggested change

/.vs

/.vscode

I feel like adding editor specific folders to the .gitignore is a bad rabbit hole, you end up adding them for every IDE. This belongs in a user level .gitignore instead.

Yeah you are right. I'll change it then.

Eshanatnight · 2022-09-21T04:43:51Z

I would like to ask for some suggestions regarding the tests. Should I classify them as a sub-project to cppfront. I tried running it via the add_custom_command but that is resulting in either by failing to find the files or giving a bunch of errors.

Colliflower · 2022-09-21T14:47:20Z

I think it might be better to split some of the content from this PR into multiple PRs btw. There are a few things that seem to be unrelated to build systems such as the .md file changes, clang-format and clang-tidy. Those getting their own PRs would clean things up and make this PR more attractive imo.

Eshanatnight · 2022-09-21T14:56:24Z

I apologise, my brain gets all over the place when I work, so it got a bit out of hand it that way.

What i thought of about the testing, is that it's better if we just keep the Tests as they are atleast for now.

Eshanatnight · 2022-09-21T19:10:21Z

The CMakeLists is complete, but I am keeping The premake5.lua file as imo it creates a better visual studio sln file than cmake.

filipsajdak · 2022-09-23T07:28:43Z

@Eshanatnight your PR is a collection of unrelated changes (adding build system files, minor edits in Markdown files) - consider moving them to separate PRs. It will make reviewing them easier.

Eshanatnight · 2022-09-23T07:36:22Z

@Eshanatnight your PR is a collection of unrelated changes (adding build system files, minor edits in Markdown files) - consider moving them to separate PRs. It will make reviewing them easier.

I apologize, I will remove the misc files and edits and remove the premake file

Eshanatnight · 2022-09-23T07:41:41Z

I have made the asked changes.
Again apologies for the mis steps.

Arthapz · 2022-09-23T16:12:08Z

I made a support for XMake https://github.com/TapzCrew/cppfront-xmake

(and the package recipe https://github.com/TapzCrew/xmake-repo/blob/main/packages/c/cppfront/xmake.lua)

JohelEGP · 2022-09-23T16:32:48Z

CMakelists.txt

+)
+
+add_executable(${PROJECT_NAME} ${SRC_FILES})
+target_include_directories(${PROJECT_NAME} PUBLIC "include")


Compiling cppfront doesn't require this.

Can you please clarify what is not required?

Line 20. You can compile cppfront without cpp2util.h.

hsutter · 2022-09-24T16:22:40Z

Thanks for this idea and energy.

How about making this a separate companion project, and I can add a wiki page of links to known companion projects to help make people aware of them?

My concern about putting it here is that it complicates what I will need to maintain, particularly at this early stage when a lot of things are still fluid and subject to change. And while I realize CMake is usually the most popular and it's a meta-build system that can generate others, if we add CMake I would expect to get questions like "why not Ninja, msbuild, Xcode, Bazel, Gradle, ...?" which I'd have to answer.

Right now I've been considering "no CMake/Bazel/..." to be a feature, in that the project is simple enough that it's easy for anyone to separately build and integrate with whatever build tools and project system they're using. Is that reasonable for now?

JohelEGP · 2022-09-24T16:25:17Z

Yes, please. I'd like to add https://github.com/JohelEGP/jegp.cmake_modules/#jegpcpp2 to the wiki, which allows to compile CMake targets with Cpp2 source files. You can see it working on CE: https://godbolt.org/z/e1r3qsE8M.

alexreinking · 2022-09-24T17:31:59Z

CMakelists.txt

+set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY 					${CMAKE_BINARY_DIR}/bin)
+set(CMAKE_RUNTIME_OUTPUT_DIRECTORY 					${CMAKE_BINARY_DIR}/bin)


This is super unfriendly to FetchContent users and totally unnecessary.

I am using MSVC cmd line. And the cmd line tool has a tendency to make to obfuscate the build dir imo thats why I added that.

alexreinking · 2022-09-24T17:32:30Z

CMakelists.txt

@@ -0,0 +1,19 @@
+cmake_minimum_required(VERSION 3.2)


CMake 3.2 predates even C++17, so this minimum is bogus.

I am sorry I had no idea that was the case. Thanks For Letting me know.

hsutter · 2022-10-01T21:35:30Z

Yes, please. I'd like to add https://github.com/JohelEGP/jegp.cmake_modules/#jegpcpp2 to the wiki, which allows to compile CMake targets with Cpp2 source files. You can see it working on CE: https://godbolt.org/z/e1r3qsE8M.

Done, thanks. Added to wiki home page

Eshanatnight added 4 commits September 19, 2022 09:57

updated Markdown files to the standard convention

6562dad

Added clang-format and clang-tidy files(should be changed by author)

322b60b

Added gitignore and git attributes files

cbd8fa2

Removed empty line from gitignore

7274b1d

Eshanatnight changed the title ~~Added BuildSystem Integration~~ Added Build System Integration Sep 19, 2022

added premake5.lua

6e76d3e

Eshanatnight and others added 3 commits September 20, 2022 22:31

Merge branch 'hsutter:main' into main

c5c585e

removed .txt from .gitignore (was conflicting with cmakelists.txt)

9942c3d

Added CMakelists.txt

e4d0fe3

JohelEGP suggested changes Sep 20, 2022

View reviewed changes

CMakelists.txt Outdated Show resolved Hide resolved

Fixed Typo in CMakelists.txt

80caab6

Eshanatnight added 4 commits September 21, 2022 07:25

Fixed Bug in premake5.lua file

7ed5c83

added .vs to gitignore

86d5ca5

Added Language Standard

ada7dcf

Commented out the test approach(IS WRONG)

f9a945e

Colliflower reviewed Sep 21, 2022

View reviewed changes

Update .gitignore

202c8e5

Finished Cmakelists

65d4da4

Eshanatnight added 2 commits September 23, 2022 13:09

removed clang-format, clang-tidy andl premake file

dde90f0

revert readme to original state

59bb005

Eshanatnight marked this pull request as ready for review September 23, 2022 07:41

JohelEGP reviewed Sep 23, 2022

View reviewed changes

removed redundant line from cmakelists

2d43604

alexreinking reviewed Sep 24, 2022

View reviewed changes

dacap mentioned this pull request Sep 25, 2022

Add CMake file + GitHub actions #14

Closed

hsutter self-assigned this Oct 1, 2022

hsutter closed this Oct 1, 2022

hsutter mentioned this pull request Oct 9, 2022

Adds CMake support #60

Closed

JohelEGP mentioned this pull request Apr 7, 2023

[BUG] Diagnose use of C++1 alternative tokens #328

Closed

		set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)
		set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin)

Conversation

Eshanatnight commented Sep 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eshanatnight commented Sep 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Frityet commented Sep 20, 2022

Uh oh!

Eshanatnight commented Sep 20, 2022

Uh oh!

Eshanatnight commented Sep 20, 2022

Uh oh!

JohelEGP left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Eshanatnight commented Sep 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JohelEGP commented Sep 20, 2022

Uh oh!

Eshanatnight commented Sep 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Eshanatnight commented Sep 21, 2022

Uh oh!

Colliflower commented Sep 21, 2022

Uh oh!

Eshanatnight commented Sep 21, 2022

Uh oh!

Eshanatnight commented Sep 21, 2022

Uh oh!

filipsajdak commented Sep 23, 2022

Uh oh!

Eshanatnight commented Sep 23, 2022

Uh oh!

Eshanatnight commented Sep 23, 2022

Uh oh!

Arthapz commented Sep 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hsutter commented Sep 24, 2022

Uh oh!

JohelEGP commented Sep 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hsutter commented Oct 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Eshanatnight commented Sep 19, 2022 •

edited

Loading

Eshanatnight commented Sep 19, 2022 •

edited

Loading

Eshanatnight commented Sep 20, 2022 •

edited

Loading

Eshanatnight commented Sep 20, 2022 •

edited

Loading

Arthapz commented Sep 23, 2022 •

edited

Loading

JohelEGP commented Sep 24, 2022 •

edited

Loading