Fix couples of issues from #36335#36453
Conversation
|
Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@SunMarc if possible, add tests to prevent regressions 🙏 |
I think we had a lot of failing tests due to that PR actually, not sure how we missed them @ydshieh @muellerzr . But happy to add maybe more fast tests with this is what is missing. |
|
failing tests are not related to this PR but I found out that is was also due to #36335. Need to fix |
|
I don't think the CI will pass so can you merge it @ArthurZucker ? |
* fix * style * better allocation * fix * fix * style * revert disk * exit * style * return if nothing to cache * dtensor guard * fix regressiion * fix regression * fix * fix
* fix * style * better allocation * fix * fix * style * revert disk * exit * style * return if nothing to cache * dtensor guard * fix regressiion * fix regression * fix * fix
What does this PR do?
This PR fixes a couple of issues seen from this PR. Here's a list:
Issues remaining for follow-up PRs
To reproduce errors coming from peft CI :
allocation issue