chore: support python 3.12, torch 2.6.0, clean up build/deps#7873
Conversation
1f7d108 to
254f3e8
Compare
|
I think I’ve narrowed down the issue. It’s not related to the Starting with This happens in the Other models (e.g. unet) may also fail to load, but I can’t get past this to try loading them easily. I’m also running into unexpected OOMs, but that also happens on I suspect we will need to raise the root issue w/ Last working commit: huggingface/transformers@981c276 The next commit introduces an python module import error which prevents the app from loading, so I'm not sure if the model loading error will occur.
The import error appears to be related to an interaction with Then, 10 or so commits later, this commit fixes the import error, and I can run the app. It is the first commit where the app loads and the model loading issue occurs. It's not clear if this specific commit introduced the model loading error.
Odds are we will need to take this up with But for now, I believe pinning |
|
Is it that there's a change that needs to be made in the compel/loading logic based on something updated in Transformers? Or do you think this was an unintentional regression? |
|
I've upgraded my Diffuser venv to the latest transformers and run an old SDXL with compel script and it at least gets as far as denoising. I've got other stuff using the GPU up so haven't run it to completion. $ pip show torch $ pip show transformers $ python sdxl_compel.py Here's the script so you can see if there's anything different to they way you load the encoder. |
|
Found the problem: So, question is, do we need this still... and, for that matter, do we need any of this file any more? |
|
I can verify that we do not need the MPS fixes with Torch 2.6.0 - these fixes were so that black images aren't produced on MPS when using float16 or bfloat16. I just checked, and the black images only appear when using |
254f3e8 to
9a99347
Compare
…itate upgrading co-dependencies. we will use uv.lock to ensure reproducibility
This allows it to pull in sentencepiece on its own. In 0.10.0, it didn't have this package listed as a dependency, but in recent releases it does. So we are able to remove sentencepiece as an explicit dep.
|
Changes:
|
|
I'm on a spring cleaning rampage. I am merging #7881 into this PR. It removes the installer scripts from the repo and updates our CI accordingly. It's been manually e2e tested. |
Summary
This PR includes all changes from #7847. I cherry-picked the changes from that PR's fork on to the origin so that I could do some test PyPI builds.
I cannot get MPS to generate - get an max recursion depth error when trying to load models.
very large traceback
I get the same error on python 3.12 and 3.11.
Related Issues / Discussions
QA Instructions
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)