[serge] Fix 10 integration tests for model gemma3 failing with output_mismatch (list output differs (8), other (2)) - #47310
Closed
sergereview[bot] wants to merge 1 commit into
Closed
Conversation
…put_mismatch` (list output differs (8), other (2))
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
CI recapDashboard: View test results in Grafana |
Collaborator
|
run-slow: gemma3 |
Contributor
|
This comment contains models: ["models/gemma3"] |
Contributor
CI ResultsCommit Info
The test failure analysis could not be completed. Please check the workflow run for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original CI failure
1/1: 10 integration tests for modelgemma3failing withoutput_mismatch(list output differs (8), other (2))tests/models/gemma3/test_modeling_gemma3.py::Gemma3IntegrationTest::test_dynamic_sliding_window_is_default[multi-gpu] (output_mismatch, seen 6/7)Relates to #47309
Fixes the
test_dynamic_sliding_window_is_defaultfailures in the Gemma3 integration group. The generation code from #40039 unsetscache_implementation="hybrid"so that models with sliding-window attention use the dynamic sliding-window cache by default. It was unsetting this value unconditionally, so an explicitcache_implementation="hybrid"passed togenerate()was ignored and aDynamicCachecontainingDynamicSlidingWindowLayerlayers was returned instead of the static hybrid cache.The patch only unsets
"hybrid"when it was not explicitly provided ingenerate()kwargs, preserving user intent.Note: The normalizer failures (
modeling_rules_doc,docstrings) are caused by a missingtransformers.models.tipsv2module /Tipsv2Configimport, which is unrelated to this change.This change was produced automatically by serge from a CI failure report. The patch was generated by an LLM and applied by serge; review before merging.
serge
v0.1.0· model:moonshotai/Kimi-K2.7-Code· 62 LLM turns · 62 tool calls · 194.5s · 2151228 in / 20968 out tokens