Skip to content

[serge] Fix 10 integration tests for model gemma3 failing with output_mismatch (list output differs (8), other (2)) #47310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sergereview wants to merge 1 commit into from
Closed

[serge] Fix 10 integration tests for model gemma3 failing with output_mismatch (list output differs (8), other (2)) #47310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/transformers/generation/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1776,7 +1776,8 @@ def _prepare_generation_config(
# `cache_implementation="hybrid"` (the static sliding window cache). For these models, we now want to use
# the dynamic sliding window cache by default, so we UNSET `cache_implementation` if it is a default value.
# (if we're inside this branch, then it is because we're using default values from the Hub)
if generation_config.cache_implementation == "hybrid":
# Only unset when the value comes from the model's default config, not when explicitly passed by the user.
if "cache_implementation" not in kwargs and generation_config.cache_implementation == "hybrid":
generation_config.cache_implementation = None

# It doesn't make sense to allow kwargs and `generation_config`, that should be mutually exclusive
Expand Down
Loading