[8.0.4][iOS] finishTransaction promise never finishes

[aijcoa]

Version of react-native-iap

8.0.4

Version of react-native

0.67.2

Platforms you faced the error (IOS or Android or both?)

iOS

Expected behavior

calling finishTransaction marks the transaction as finished

Actual behavior

Any code after the await RNIap.finishTransaction is not executed, and the transaction is reattempted after each relaunch of the app.

Tested environment (Emulator? Real Device?)

Real device

Steps to reproduce the behavior

Purchase a product in sandbox, call finishTransaction, check if some code after the promise is executed.

Here is my listener:

purchaseUpdatedListener = RNIap.purchaseUpdatedListener(
    async (purchase: RNIap.InAppPurchase | RNIap.SubscriptionPurchase) => {
      const receipt = purchase.transactionReceipt;

      try {
        if (receipt) {
          const decodedReceipt = await decodeAppleReceipt(receipt);
          const isValid = await isSubValid(decodedReceipt);

          if (isValid) {
            const { latest_receipt_info: latestReceipts }: any = decodedReceipt;
            const sortedReceiptInfo = latestReceipts.sort(
              (
                a: { original_purchase_date_ms: number },
                b: { original_purchase_date_ms: number },
              ) => b.original_purchase_date_ms - a.original_purchase_date_ms,
            );
            let latestReceiptInfo = sortedReceiptInfo[sortedReceiptInfo.length - 1];
            console.log(latestReceiptInfo);

            const subPrice = await getSubPrice(latestReceiptInfo.product_id);
            const subDuration = getSubDuration(latestReceiptInfo.product_id);

            latestReceiptInfo = {
              ...latestReceiptInfo,
              subscription_price: subPrice,
            };

            // Persist the purchase on backend API
            const persistedPurchase = await persistSubscriptionIOS(latestReceiptInfo, sessionId);
            const persistedPurchaseId: string = persistedPurchase.persistPurchase.id;

            latestReceiptInfo = {
              ...latestReceiptInfo,
              persisted_purchase_id: persistedPurchaseId,
              source: 'ios',
              subscription_duration: subDuration,
            };


            // Activate the subscription on backend API
            const deliveryResult = await activateSubscription(latestReceiptInfo, sessionId);

            if (isSuccess(deliveryResult)) {
              console.log('deliveryResult is true');
              await RNIap.finishTransaction(purchase, false);
              console.log('finish transaction done');
              onSuccess?.();
            }
          }
        }
      } catch (error) {
        console.error(error);
      }
    },
  );

The console.log of finish transaction done is never executed, neither my onSuccess callback. However the console.log before finishTransaction is logged.

[mitchdowney]

I'm running into this too. Could this be related to the changes in #1637? b80d86a#diff-f5845f8cdcafa3f8ab197caa911871c32772df9036f11d7cf5a33a2e23d430c6L49-R51

[manamelacedric]

I am also having the same issue

[aijcoa]

I have downgraded to 7.5.6 until this is resolved.

[mikeportanova]

I am experiencing this issue as well.

[josejhj2]

Same here, downgraded to 7.5.6 to resolve issue.

[juniorklawa]

Same here...

[aijcoa]

This seems to be fixed for me in 8.0.5

[mikeportanova]

This problem definitely persists in 8.0.5. How are you implementing it., @aijcoa?

[taskrik]

I still have the same issue in v8.0.5. @aijcoa Can you please provide more info on how you managed to solve it?

[mikeportanova]

In looking into this, the main issue is that the resolve/reject blocks are never called in finishTransaction() in RNIapIos.swift.

@objc public func finishTransaction( _ transactionIdentifier: String, resolve: @escaping RCTPromiseResolveBlock = { _ in }, reject: @escaping RCTPromiseRejectBlock = { _, _, _ in } ) { finishTransaction(withIdentifier: transactionIdentifier) }

simply adding a resolve(nil) call after finishTransaction() solves the issue, but is a brittle solution here.

[aijcoa]

@taskrik @mikeportanova I updated to 8.0.5 with the same code in the original post and finish transaction done is logged , I tested with an iOS product, not a subscription (I will try that tomorrow). I'll keep this issue open.

[taskrik]

Thank you for your response @aijcoa! Yeah, I am trying to use it with subscriptions. Maybe the issue is with that. I'll try the products tomorrow to see if I get the same results.

[mikeportanova]

@taskrik same, I am trying with renewable subscriptions. Nothing ever resolves or rejects the Swift promise created by finishTransaction(), so it never completes, even after the Swift code has called SKPaymentQueue.default().finishTransaction(transaction)