Fixes finishTransaction not resolving for iOS#1665
Merged
hyochan merged 2 commits intohyochan:mainfrom Mar 20, 2022
Merged
Conversation
Contributor
Author
|
Should be merged in tandem with #1662 |
Contributor
Author
|
This could also be related: #1664 |
hyochan
approved these changes
Mar 20, 2022
Owner
hyochan
left a comment
hyochan
left a comment
There was a problem hiding this comment.
I couldn't test this now but I'll try to merge this since this looks a bit urgent.
Thanks @andresesfm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1645 by calling resolve once the
SKPaymentQueuefinishTransactionhas been triggeredFollowing the history of the file, it looks like this was broken trying to fix #1637 , by adding the promise methods in the header but not calling resolve/reject. I have fixed both methods (finishTransaction and clearTransaction) here credit goes to the people commenting on the issue, it helped a lot to narrow the problem