Skip to content

update: Update MSFT Contrib Ops in OVEP - #521

Merged
sfatimar merged 3 commits into
ovep-developfrom
ankit/data_ops_changes
Feb 11, 2025
Merged

update: Update MSFT Contrib Ops in OVEP#521
sfatimar merged 3 commits into
ovep-developfrom
ankit/data_ops_changes

Conversation

@ankitm3k

@ankitm3k ankitm3k commented Dec 11, 2024

Copy link
Copy Markdown

Description

This PR Updates the latest OV supported Contrib Ops in OVEP

@MayureshV1

MayureshV1 commented Dec 12, 2024

Copy link
Copy Markdown

@ankitm3k, Can you please test a few models with these custom ops and ensure only the backends/ devices that are functional are called out as supported.

saurabhkale17
saurabhkale17 suggested changes Dec 18, 2024
View reviewed changes
Comment thread onnxruntime/core/providers/openvino/ov_versions/data_ops.cc Outdated
@ankitm3k
ankitm3k force-pushed the ankit/data_ops_changes branch 3 times, most recently from 63560cc to 562d1fc Compare January 24, 2025 09:36
@vthaniel
vthaniel force-pushed the ankit/data_ops_changes branch from 8d43b06 to 562d1fc Compare January 24, 2025 12:31
@ankitm3k
ankitm3k changed the base branch from ovep-develop-lnl-1.4 to ovep-develop January 24, 2025 12:39
@n1harika

n1harika commented Jan 24, 2025

Copy link
Copy Markdown

Modified data_ops.cc to remove unsupported ops, namely:

SkipSimplifiedLayerNormalization
SimplifiedLayerNormalization
QuickGelu
FusedMatMul

This PR adds support for:

Attention
BiasGelu
EmbedLayerNormalization
FusedConv
FusedGemm
MatMulNBits
SkipLayerNormalization

@vthaniel
vthaniel force-pushed the ankit/data_ops_changes branch 2 times, most recently from a53fa99 to c8ba719 Compare January 24, 2025 14:12
@ankitm3k
ankitm3k force-pushed the ankit/data_ops_changes branch from c8ba719 to b5b8e5a Compare January 28, 2025 11:51
@ankitm3k
ankitm3k force-pushed the ankit/data_ops_changes branch from b5b8e5a to b727038 Compare February 4, 2025 18:00
@n1harika

n1harika commented Feb 6, 2025

Copy link
Copy Markdown

Spreadsheet used in testing the various operators: https://intel-my.sharepoint.com/:x:/p/ankit_maheshkar/EeMj4cZ-2XNEpoWznBgtKc8B6f7oKR9uZjlWNKUH0VYqdg?e=dihHPM

JIRA: https://jira.devtools.intel.com/browse/CVS-160502

@ankitm3k
ankitm3k force-pushed the ankit/data_ops_changes branch from b727038 to e1027cc Compare February 6, 2025 14:07
@ankitm3k
ankitm3k force-pushed the ankit/data_ops_changes branch from e1027cc to e8e3a18 Compare February 7, 2025 06:27
@sfatimar

sfatimar commented Feb 10, 2025

Copy link
Copy Markdown

@ankitm3k PR is unblocked Please rebase, review and ready to merge

@vthaniel
vthaniel force-pushed the ankit/data_ops_changes branch from c045197 to 935c8db Compare February 10, 2025 13:18
@ankitm3k
ankitm3k force-pushed the ankit/data_ops_changes branch 2 times, most recently from 27b5c23 to 875d055 Compare February 10, 2025 14:48
@ankitm3k

ankitm3k commented Feb 10, 2025

Copy link
Copy Markdown
Author

@ankitm3k PR is unblocked Please rebase, review and ready to merge

LGTM. Reviewed it

@sfatimar

sfatimar commented Feb 11, 2025

Copy link
Copy Markdown

LGTM

@sfatimar
sfatimar merged commit 059f7c1 into ovep-develop Feb 11, 2025
sfatimar pushed a commit that referenced this pull request Feb 11, 2025
@ankitm3k @n1harika @jatinwadhwa921
update: Update MSFT Contrib Ops in OVEP (#521)
f84614c 
* update: Update MSFT Contrib Ops from OV

* modified data_ops.cc to remove unsupported ops

* disabled tests for EmbedLayerNormalisation and MatMulNBits

---------

Co-authored-by: n1harika <niharika.sathish@intel.com>
ankitm3k added a commit that referenced this pull request Feb 13, 2025
@ankitm3k @n1harika
update: Update MSFT Contrib Ops in OVEP (#521)
4cdfc77 
* update: Update MSFT Contrib Ops from OV

* modified data_ops.cc to remove unsupported ops

* disabled tests for EmbedLayerNormalisation and MatMulNBits

---------

Co-authored-by: n1harika <niharika.sathish@intel.com>
sfatimar pushed a commit that referenced this pull request Feb 13, 2025
@rayngun @jatinwadhwa921
@ankitm3k @n1harika
Fix failing dimension check for MAX operation. (#566)
a153164 
* Internal ci for PTL 1.1 (#523)

* update: Update MSFT Contrib Ops in OVEP (#521)

* update: Update MSFT Contrib Ops from OV

* modified data_ops.cc to remove unsupported ops

* disabled tests for EmbedLayerNormalisation and MatMulNBits

---------

Co-authored-by: n1harika <niharika.sathish@intel.com>

* Add Max op to no_dimension_supported list

---------

Co-authored-by: jatinwadhwa921 <110383850+jatinwadhwa921@users.noreply.github.com>
Co-authored-by: Ankit Maheshkar <ankit.maheshkar@intel.com>
Co-authored-by: n1harika <niharika.sathish@intel.com>
ankitm3k added a commit that referenced this pull request Feb 17, 2025
@ankitm3k @n1harika
update: Update MSFT Contrib Ops in OVEP (#521)
06dcba4 
* update: Update MSFT Contrib Ops from OV

* modified data_ops.cc to remove unsupported ops

* disabled tests for EmbedLayerNormalisation and MatMulNBits

---------

Co-authored-by: n1harika <niharika.sathish@intel.com>
ankitm3k added a commit that referenced this pull request Feb 17, 2025
@rayngun @jatinwadhwa921
@ankitm3k @n1harika
Fix failing dimension check for MAX operation. (#566)
4986b48 
* Internal ci for PTL 1.1 (#523)

* update: Update MSFT Contrib Ops in OVEP (#521)

* update: Update MSFT Contrib Ops from OV

* modified data_ops.cc to remove unsupported ops

* disabled tests for EmbedLayerNormalisation and MatMulNBits

---------

Co-authored-by: n1harika <niharika.sathish@intel.com>

* Add Max op to no_dimension_supported list

---------

Co-authored-by: jatinwadhwa921 <110383850+jatinwadhwa921@users.noreply.github.com>
Co-authored-by: Ankit Maheshkar <ankit.maheshkar@intel.com>
Co-authored-by: n1harika <niharika.sathish@intel.com>
ankitm3k added a commit that referenced this pull request Feb 17, 2025
@ankitm3k @n1harika
update: Update MSFT Contrib Ops in OVEP (#521)
dae8097 
* update: Update MSFT Contrib Ops from OV

* modified data_ops.cc to remove unsupported ops

* disabled tests for EmbedLayerNormalisation and MatMulNBits

---------

Co-authored-by: n1harika <niharika.sathish@intel.com>
ankitm3k added a commit that referenced this pull request Feb 17, 2025
@rayngun @jatinwadhwa921
@ankitm3k @n1harika
Fix failing dimension check for MAX operation. (#566)
9068f50 
* Internal ci for PTL 1.1 (#523)

* update: Update MSFT Contrib Ops in OVEP (#521)

* update: Update MSFT Contrib Ops from OV

* modified data_ops.cc to remove unsupported ops

* disabled tests for EmbedLayerNormalisation and MatMulNBits

---------

Co-authored-by: n1harika <niharika.sathish@intel.com>

* Add Max op to no_dimension_supported list

---------

Co-authored-by: jatinwadhwa921 <110383850+jatinwadhwa921@users.noreply.github.com>
Co-authored-by: Ankit Maheshkar <ankit.maheshkar@intel.com>
Co-authored-by: n1harika <niharika.sathish@intel.com>
sfatimar
sfatimar reviewed Apr 3, 2025
View reviewed changes

@sfatimar sfatimar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfatimar sfatimar sfatimar left review comments
@n1harika n1harika n1harika left review comments
@vthaniel vthaniel Awaiting requested review from vthaniel
@jatinwadhwa921 jatinwadhwa921 Awaiting requested review from jatinwadhwa921
@saurabhkale17 saurabhkale17 Awaiting requested review from saurabhkale17

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ankitm3k @MayureshV1 @n1harika @sfatimar @saurabhkale17