Skip to content

Fix failing dimension check for MAX operation. - #566

Merged
sfatimar merged 3 commits into
intel:ovep-developfrom
rayngun:max_fix
Feb 13, 2025
Merged

Fix failing dimension check for MAX operation.#566
sfatimar merged 3 commits into
intel:ovep-developfrom
rayngun:max_fix

Conversation

@rayngun

@rayngun rayngun commented Feb 6, 2025

Copy link
Copy Markdown

No description provided.

@rayngun
rayngun marked this pull request as ready for review February 6, 2025 01:16
@sfatimar

sfatimar commented Feb 7, 2025

Copy link
Copy Markdown

@saurabhkale17 please review

@sfatimar

Copy link
Copy Markdown

@saurabhkale17 @rayngun PR is unblocked now, Please rebase and ready to merge. Please finish review process.

@saurabhkale17

Copy link
Copy Markdown

@rayngun Can you please rebase the branch
27 file changes.

jatinwadhwa921 and others added 2 commits February 11, 2025 17:03
* update: Update MSFT Contrib Ops from OV

* modified data_ops.cc to remove unsupported ops

* disabled tests for EmbedLayerNormalisation and MatMulNBits

---------

Co-authored-by: n1harika <niharika.sathish@intel.com>
@rayngun rayngun reopened this Feb 11, 2025
@saurabhkale17

Copy link
Copy Markdown

LGTM.
@sfatimar should I merge it in ?

@sfatimar

Copy link
Copy Markdown

Internal CI is failing @jatinwadhwa921 I am merging anyways as it is open for long time.

@sfatimar
sfatimar merged commit a153164 into intel:ovep-develop Feb 13, 2025
ankitm3k added a commit that referenced this pull request Feb 17, 2025
* Internal ci for PTL 1.1 (#523)

* update: Update MSFT Contrib Ops in OVEP (#521)

* update: Update MSFT Contrib Ops from OV

* modified data_ops.cc to remove unsupported ops

* disabled tests for EmbedLayerNormalisation and MatMulNBits

---------

Co-authored-by: n1harika <niharika.sathish@intel.com>

* Add Max op to no_dimension_supported list

---------

Co-authored-by: jatinwadhwa921 <110383850+jatinwadhwa921@users.noreply.github.com>
Co-authored-by: Ankit Maheshkar <ankit.maheshkar@intel.com>
Co-authored-by: n1harika <niharika.sathish@intel.com>
ankitm3k added a commit that referenced this pull request Feb 17, 2025
* Internal ci for PTL 1.1 (#523)

* update: Update MSFT Contrib Ops in OVEP (#521)

* update: Update MSFT Contrib Ops from OV

* modified data_ops.cc to remove unsupported ops

* disabled tests for EmbedLayerNormalisation and MatMulNBits

---------

Co-authored-by: n1harika <niharika.sathish@intel.com>

* Add Max op to no_dimension_supported list

---------

Co-authored-by: jatinwadhwa921 <110383850+jatinwadhwa921@users.noreply.github.com>
Co-authored-by: Ankit Maheshkar <ankit.maheshkar@intel.com>
Co-authored-by: n1harika <niharika.sathish@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants