Skip to content
This repository was archived by the owner on Mar 14, 2020. It is now read-only.

[FileIO] Enable image upload feature in property view#101

Merged
sbryan merged 2 commits into
intel:masterfrom
DonnaWuDongxia:enable-upload
Jun 28, 2012
Merged

[FileIO] Enable image upload feature in property view#101
sbryan merged 2 commits into
intel:masterfrom
DonnaWuDongxia:enable-upload

Conversation

@DonnaWuDongxia

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/js/views/property.js

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to have a small button whose caption is "..." on the right side of the input.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I'll merge this as is, but from a UI and design perspective, it needs to be significantly improved

Also, I found my self wishing I could just pick from files I already uploaded, and not have to upload another. I'd like to see a select menu here as well if there are already files uploaded, making sure only valid IMAGE file types are shown

sbryan added a commit that referenced this pull request Jun 28, 2012
Status of pull requests included in this integration request:
- #101 OK, merged, with comments (#r1072658)
- #85  OK, merged
@sbryan sbryan merged commit 9375f1b into intel:master Jun 28, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants