This repository was archived by the owner on Mar 14, 2020. It is now read-only.
[Widgets] Deeply extend widget#85
Merged
Merged
Conversation
Currently only properties are inherited when extending a widget, this patch also extend other defintions of a wdiget. Be cautious that all elements of an array should be specified in the child type if you don't want to override them.
As each widget has all the fields extended with base widget, we don't have to build hierachy when getting property fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only properties are inherited when extending a widget,
this patch also extend other defintions of a wdiget. Be cautious
that all elements of an array should be specified in the child
type if you don't want to override them.