Skip to content
This repository was archived by the owner on Mar 14, 2020. It is now read-only.

[ADM] Implemented showInProperty() for widget property exposed to user.#131

Closed
xuqingkuang wants to merge 1 commit into
intel:masterfrom
xuqingkuang:showInProperty
Closed

[ADM] Implemented showInProperty() for widget property exposed to user.#131
xuqingkuang wants to merge 1 commit into
intel:masterfrom
xuqingkuang:showInProperty

Conversation

@xuqingkuang

Copy link
Copy Markdown
Contributor

The function will determine the property whether to show in property view.

The function will determine the property whether to show in property view.
Comment thread src/js/views/property.js

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing ";"

@grgustaf

Copy link
Copy Markdown
Contributor

Hmm, I was actually daydreaming about maybe needing such a function earlier this morning. So I'll be glad to take it. I think I'd prefer to call it:

propertyUserVisible()

Can I ask what you're wanting to use it for?

@xuqingkuang

Copy link
Copy Markdown
Contributor Author

Geoff, In fact I'm feeling showInProperty is enough to describe the function, and the name make it be uniform with showInPalette.

The property will able to make a property to hide in property view, such as the event properties - xuqingkuang@e589e4e#L2R76

And it's need by Yongfeng Wu to completed his feature too.

@zhizhangchen

Copy link
Copy Markdown
Contributor

Replaced by #144

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants