This repository was archived by the owner on Mar 14, 2020. It is now read-only.
[ADM] Implemented propertyVisible() for widget property exposed to user.#141
Closed
xuqingkuang wants to merge 1 commit into
Closed
[ADM] Implemented propertyVisible() for widget property exposed to user.#141xuqingkuang wants to merge 1 commit into
xuqingkuang wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Now that the name has been changed to propertyVisible, I think the function documentation should also change accordingly. For example:
"Tests whether this property is visible to user, for example, property view can use it to decide if it will show this property. "
And, as discussed in another PR request, it is preferred that this function is implemented in BWidget only.
The function will determine the property whether to show in property view.
Contributor
Author
|
Close for upload a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function will determine the property whether to show in property view.
Replace #131 by @zhizhangchen's comments.
@grgustaf Because of propertyUserVisible is too long and hard to fit the size of docs in widgets.js, so I still use 'propertyVisible' as the function and attribute name.