Skip to content
This repository was archived by the owner on Mar 14, 2020. It is now read-only.

Integration 20120625#88

Closed
zhizhangchen wants to merge 11 commits into
intel:masterfrom
zhizhangchen:integration-20120625
Closed

Integration 20120625#88
zhizhangchen wants to merge 11 commits into
intel:masterfrom
zhizhangchen:integration-20120625

Conversation

@zhizhangchen

Copy link
Copy Markdown
Contributor

#84, #85, #8, #81, #83 included. They are independent. #83, #84 are more important than others

maxyu and others added 11 commits April 20, 2012 09:29
This patch set the text font in jqm_header.svg and set to use
OpenSans-SB in two other places
Currently only properties are inherited when extending a widget,
this patch also extend other defintions of a wdiget. Be cautious
that all elements of an array should be specified in the child
type if you don't want to override them.
Page, Header and Footer have been supported, other widget can
inherit the "Background" widget to get background support
@zhizhangchen zhizhangchen mentioned this pull request Jun 25, 2012
@sbryan

sbryan commented Jun 26, 2012

Copy link
Copy Markdown
Contributor

This commit needs to be rebased on lastest version of the .svg files (converted from UTF-16, UTF-8)

Also, this STILL does not actually solve the problem on my test/development environment.

In my explorations of this problem, the ONLY way to ensure that the font is loaded and used when painting the tags is to specify a fully qualified href, including protocol, host, port and absolute path.

This is of course a problem since we currently support running RIB without any build steps, so we can never actually know the full URI to be used. The only solutions I can think of is 1) include node.js in the project and require it to be the "server" used to access RIB, or 2) add a build step required before using RIB that will set these values once, then they will be appropriate for the developers/users actual configuration.

@sbryan

sbryan commented Jun 26, 2012

Copy link
Copy Markdown
Contributor

Status Update:

@zhizhangchen

Copy link
Copy Markdown
Contributor Author

Is there any way that we can detect the full URI at run time, and use that for the svg files? For example, window.location.protocol and window.location.host

@sbryan

sbryan commented Jun 26, 2012

Copy link
Copy Markdown
Contributor

Sadly no, not when the SVG is used as the value to the src attribute of an element. I actually tested this today with javascript embedded into the SVG itself. It works fine when loading the SVG by itself directly in the browser, or when the SVG is inlined into the DOM, but not when referenced from an element.

@sbryan

sbryan commented Jun 26, 2012

Copy link
Copy Markdown
Contributor

Closing, see comments for status details

@sbryan sbryan closed this Jun 26, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants