Skip to content

fix(input): exclude date inputs from scroll assist - #25749

Merged
liamdebeasi merged 5 commits into
mainfrom
FW-1997
Aug 11, 2022
Merged

fix(input): exclude date inputs from scroll assist#25749
liamdebeasi merged 5 commits into
mainfrom
FW-1997

Conversation

@liamdebeasi

@liamdebeasi liamdebeasi commented Aug 10, 2022

Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25745 (see link for explanation of why this bug happens)

What is the new behavior?

  • ion-input elements with type="date" or type="datetime-local" no longer get registered with the scroll assist utility.

Does this introduce a breaking change?

  • Yes
  • No

Other information

main branch
beforedate.mp4
after2.mp4

A few things to notice:

  1. In the main video, observe that the datepicker appears from the wrong reference point (at the top of the screen instead of where the input exists on the page.
  2. In the main video observe that after opening the datepicker once it is impossible to tap anything else on the page.

@github-actions github-actions Bot added the package: core @ionic/core package label Aug 10, 2022
@liamdebeasi
liamdebeasi marked this pull request as ready for review August 10, 2022 20:49
@liamdebeasi
liamdebeasi requested a review from a team August 10, 2022 20:49
Comment thread core/src/utils/input-shims/input-shims.ts Outdated
Co-authored-by: Sean Perkins <sean@ionic.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: <ion-input type="date"> completely freezes mobile safari when switching between two inputs

3 participants