fix(input): exclude date inputs from scroll assist - #25749
Merged
Conversation
liamdebeasi
marked this pull request as ready for review
August 10, 2022 20:49
sean-perkins
approved these changes
Aug 11, 2022
Co-authored-by: Sean Perkins <sean@ionic.io>
averyrousseau
approved these changes
Aug 11, 2022
7 tasks
This was referenced Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: resolves #25745 (see link for explanation of why this bug happens)
What is the new behavior?
type="date"ortype="datetime-local"no longer get registered with the scroll assist utility.Does this introduce a breaking change?
Other information
mainbeforedate.mp4
after2.mp4
A few things to notice:
mainvideo, observe that the datepicker appears from the wrong reference point (at the top of the screen instead of where the input exists on the page.mainvideo observe that after opening the datepicker once it is impossible to tap anything else on the page.