Skip to content

fix(input): exclude date inputs from scroll assist #25749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liamdebeasi merged 5 commits into from
Aug 11, 2022
Merged

fix(input): exclude date inputs from scroll assist #25749

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
917850b
fix(input): exclude date inputs from scroll assist
liamdebeasi Aug 10, 2022
6c01129
Merge branch 'main' into FW-1997
liamdebeasi Aug 10, 2022
2ac3048
Merge branch 'main' into FW-1997
liamdebeasi Aug 10, 2022
835219a
Update core/src/utils/input-shims/input-shims.ts
liamdebeasi Aug 11, 2022
b7ff7a6
Merge branch 'main' into FW-1997
averyrousseau Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion core/src/utils/input-shims/input-shims.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,20 @@ export const startInputShims = (config: Config) => {
hideCaretMap.set(componentEl, rmFn);
}

if (SCROLL_ASSIST && (!!scrollEl || !!footerEl) && scrollAssist && !scrollAssistMap.has(componentEl)) {
/**
* date/datetime-locale inputs on mobile devices show date picker
* overlays instead of keyboards. As a result, scroll assist is
* not needed. This also works around a bug in iOS <16 where
* scroll assist causes the browser to lock up. See FW-1997.
*/
const isDateInput = inputEl.type === 'date' || inputEl.type === 'datetime-local';
if (
SCROLL_ASSIST &&
!isDateInput &&
(!!scrollEl || !!footerEl) &&
scrollAssist &&
!scrollAssistMap.has(componentEl)
) {
const rmFn = enableScrollAssist(componentEl, inputEl, scrollEl, footerEl, keyboardHeight);
scrollAssistMap.set(componentEl, rmFn);
}
Expand Down