Skip to content

fix(datetime): only log out of bounds warning if value set - #25835

Merged
liamdebeasi merged 13 commits into
mainfrom
FW-2145
Aug 30, 2022
Merged

fix(datetime): only log out of bounds warning if value set#25835
liamdebeasi merged 13 commits into
mainfrom
FW-2145

Conversation

@liamdebeasi

@liamdebeasi liamdebeasi commented Aug 26, 2022

Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25833

What is the new behavior?

  • On component load, we only warn about out of bounds values if the value prop was actually set.
  • We no longer warn about out of bounds values if we are defaulting to today's date as that date will then be moved in bounds below. The warning is there to inform developers that they set an out of bounds value.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions Bot added the package: core @ionic/core package label Aug 26, 2022
@liamdebeasi
liamdebeasi marked this pull request as ready for review August 26, 2022 14:47
@liamdebeasi
liamdebeasi requested a review from a team August 26, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: passing max only causes ion-datetime is out of bounds

3 participants