Skip to content

ipnsfs#923

Merged
jbenet merged 9 commits intomasterfrom
ipns/ipnsfs
Mar 18, 2015
Merged

ipnsfs#923
jbenet merged 9 commits intomasterfrom
ipns/ipnsfs

Conversation

@whyrusleeping
Copy link
Member

In this PR i implement a 'mock' in memory mutable filesystem to be used as the backend for the fuse ipns interface.

This is PR number 6 of the ipns set

@whyrusleeping whyrusleeping added the status/in-progress In progress label Mar 12, 2015
ipnsfs/dir.go Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference? to what?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oxDEADC0DE

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove it

@jbenet
Copy link
Member

jbenet commented Mar 17, 2015

@whyrusleeping network-test failed again: https://build.protocol-dev.com/job/network-test/2012/console Error: blockstore: block not found.

the common failures of network-test are:

  • it actually succeeds but gets marked as failure (not sure why)
  • it runs too long on a starved VM and gets killed early.

other than that network-test is reliable. this failure is not common for network-test. something is going on. either in this PR, or in code recently merged.

@whyrusleeping
Copy link
Member Author

@jbenet it also failed over in @chriscool's latest PR

@jbenet
Copy link
Member

jbenet commented Mar 17, 2015

Oh uh. This is bad news. Master may be broken. We should bisect 


Sent from Mailbox

On Mon, Mar 16, 2015 at 6:18 PM, Jeromy Johnson notifications@github.com
wrote:

@jbenet it also failed over in @chriscool's latest PR

Reply to this email directly or view it on GitHub:
#923 (comment)

@jbenet
Copy link
Member

jbenet commented Mar 17, 2015

@jbenet it also failed over in @chriscool's latest PR

No, the failure in #931 is: https://build.protocol-dev.com/job/network-test/2009/console which is the "succeeded but mistakenly marked as failed."

Ok, i've tested master 10x times (on jupiter) and it failed 0/10 times.
I've tested this PR 5x times (on jupiter) and it failed 5/5 times.

There's something wrong in this PR. @whyrusleeping can you not repro the failure locally? Look at the test console output: https://build.protocol-dev.com/job/network-test/2012/console

@whyrusleeping
Copy link
Member Author

Thats really weird, it looks like only client_1 ever starts doing anything..

This was referenced Mar 17, 2015
@whyrusleeping whyrusleeping force-pushed the ipns/ipnsfs branch 4 times, most recently from 0c623e8 to 7c18acb Compare March 18, 2015 02:47
@whyrusleeping whyrusleeping force-pushed the ipns/ipnsfs branch 3 times, most recently from 3538069 to 7ad8dd8 Compare March 18, 2015 04:57
jbenet added a commit that referenced this pull request Mar 18, 2015
@jbenet jbenet merged commit c5fbc66 into master Mar 18, 2015
@jbenet jbenet removed the status/in-progress In progress label Mar 18, 2015
@jbenet jbenet deleted the ipns/ipnsfs branch March 18, 2015 05:12
@whyrusleeping whyrusleeping restored the ipns/ipnsfs branch March 19, 2015 04:48
@jbenet jbenet deleted the ipns/ipnsfs branch March 31, 2015 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants