Conversation
It looks like there were two problems: - "read" command probably needs the name of the variable it reads into - [[ didn't work This might be because on Linux /bin/sh is sometimes not bash. For example on Ubuntu it is a symlink to dash. License: MIT Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Contributor
Author
|
The Jenkins network test failed, but that is not related. |
Member
|
@jbenet ive never been all that confident about the network test. I think the reason we dont normally see it fail is because other things end up failing first... |
jbenet
added a commit
that referenced
this pull request
Mar 17, 2015
test/bin: fix continueyn on Linux
This was referenced Mar 17, 2015
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like there were two problems:
it reads into
This might be because on Linux /bin/sh is sometimes not
bash. For example on Ubuntu it is a symlink to dash.
This should fix issue #927
License: MIT
Signed-off-by: Christian Couder chriscool@tuxfamily.org