Fix a mild race condition in mount_darwin.go#956
Closed
kkoroviev wants to merge 1 commit intoipfs:masterfrom
Closed
Fix a mild race condition in mount_darwin.go#956kkoroviev wants to merge 1 commit intoipfs:masterfrom
mount_darwin.go#956kkoroviev wants to merge 1 commit intoipfs:masterfrom
Conversation
Contributor
Author
|
It's better not to merge this, but modify the upstream. |
Contributor
Author
|
CC @tv42. |
Contributor
|
Good catch, working on it. |
Member
|
yay open source at work \o/ -- gj @kkoroviev |
Contributor
|
Through the power of Git, I just literally cherry-picked that commit and all the paths and everything just worked right! Fixed in bazil/fuse@79d103f |
Merged
Contributor
|
Closing in favor of #958. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in the process of fixing #945.
It doesn't solve #945, but it solves the race conditions that I've mentioned there.