Conversation
There was a problem hiding this comment.
no idea why godep save -r ./... didn't pick up this one...
cc @jbenet - wait with merge until this is fixed
There was a problem hiding this comment.
I'm even more confused now..
I cloned this branch into an empty GOPATH on two non-darwin machines and it builds fine..
Am I missing something about this syscallx package?
cc @tv42
There was a problem hiding this comment.
@cryptix Not sure what you're talking about. That diff looks like commit 3c90b2396ff41bbe52a7b58b606d75cf47610a68 in bazil.org/fuse.
There was a problem hiding this comment.
@tv42 I was confused that godep didn't vendor golang.org/x/sys/unix and didn't rewrite the import path here to prefix/_workspace/src/...
My (way too nebulous) question for you was if the bazil.org/fuse/fs -> bazil.org/fuse/syscallx -> golang.org/x/sys/unix import chain is somehow conditional. I could have checked this myself this morning - syscallx is only included in the tests of bazil.org/fuse/fs so godep is correct (it doesn't respect test deps at all) with not including it.
My brain was only faking higher states of awareness, I guess. Sorry for the noise.
@jbenet we can move forward.
|
So many deps changing in one PR! LGTM |
Motivation was the upstream fix of #956.
I updated
jbenet/go-reuseportas well, which closes #943 for now. It was to big for one PR anyway.This PR also contains large-ish upstream changes from the following deps:
and a couple of smaller ones.
Also removes
gorilla/contextandgorilla/mux. I assume they could have been dropped since #887.