Assert the side-menu filter by invariant, not by row totals - #47
Merged
Conversation
The test read the total row count and the target group's count on the way in, then asserted the filtered board matched them. The board settles as states arrive, so both were races: it failed on a loaded runner during the 4.0.0 release rehearsal, having passed on the pull request minutes earlier. Asserts what narrowing to a group actually means instead -- one section, named the group, and every row in it carrying that group -- and that picking it again brings a second section back. No count taken before the board is settled. Three consecutive local runs green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 4.0.0 release rehearsal failed on
Dashboard_SideMenu_NarrowsTheListToOneGroup, which had passed on #46 minutes earlier.The test read the total row count and the target group's count on the way in, then asserted the filtered board matched them. The board settles as its states arrive, so both reads were races — under a loaded runner they landed on a partially-populated list.
It now asserts what narrowing to a group means, rather than a number taken beforehand: exactly one section, named the group, every row in it carrying that group, and a second section back when the entry is picked again. Three consecutive local runs green.