Skip to content

Assert the side-menu filter by invariant, not by row totals #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivanvyd merged 1 commit into from
Jul 30, 2026
Merged

Assert the side-menu filter by invariant, not by row totals #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions tests/Healthie.Tests.E2E/DashboardGroupingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,19 +136,27 @@ public async Task Dashboard_SideMenu_NarrowsTheListToOneGroup(ProviderSetup setu
await using var app = await SampleApp.StartAsync(setup, Ct);
var page = await OpenDashboardAsync(app);

var everything = await page.Locator(".hpm-row").CountAsync();
var inTarget = await GroupFor(page, TargetGroup).Locator(".hpm-row").CountAsync();
Assert.True(inTarget > 0 && inTarget < everything);
// Asserted as invariants rather than against row totals taken up front: the board settles as
// states arrive, so a count read on the way in is a race, and this failed once on a loaded
// runner for exactly that reason.
await Assertions.Expect(page.Locator(".hpm-group").First).ToBeVisibleAsync();

var entry = page.Locator(".hpm-nav-item").Filter(new() { HasTextString = TargetGroup });
await entry.ClickAsync();

await Assertions.Expect(page.Locator(".hpm-row")).ToHaveCountAsync(inTarget);
await Assertions.Expect(entry).ToHaveAttributeAsync("aria-current", "true");

// Narrowed to one group: exactly one section, and every row in it carries that group.
await Assertions.Expect(page.Locator(".hpm-group")).ToHaveCountAsync(1);
await Assertions.Expect(page.Locator(".hpm-group-name")).ToHaveTextAsync(TargetGroup);

var groups = await page.Locator(".hpm-row .hpm-chip--group").AllTextContentsAsync();
Assert.NotEmpty(groups);
Assert.All(groups, group => Assert.Equal(TargetGroup, group.Trim()));

// Picking it again is the way back, so the menu cannot strand anyone in one group.
await entry.ClickAsync();
await Assertions.Expect(page.Locator(".hpm-row")).ToHaveCountAsync(everything);
await Assertions.Expect(entry).Not.ToHaveAttributeAsync("aria-current", "true");
await Assertions.Expect(page.Locator(".hpm-group").Nth(1)).ToBeVisibleAsync();

browser.AssertNoErrors(page);
}
Expand Down