Scope the about-popover assertion to its own dialog - #49
Merged
Conversation
This test blocked two releases and passed every pull request, which is the signature of a locator that resolves to a different number of elements depending on timing. ".hpm-popover-head .hpm-tag" matched the event log's header as well as the about dialog's, so whenever both were in the DOM it was a strict-mode violation rather than an assertion. Scoped to the about dialog by its accessible name, and asserted positively: the tag has to look like a version. The old assertion was a negative, which also passes when the element is missing entirely -- so it could only ever fail for the wrong reasons. Three consecutive runs green, and the full suite is 53/53.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dashboard_LegendAndAbout_…failed the 4.0.0 rehearsal and the 4.1.0 release, and passed every PR run..hpm-popover-head .hpm-tagmatches the event log's header as well as the about dialog's, so whenever both were in the DOM the locator resolved to two elements — a strict-mode violation, not an assertion.Scoped to the about dialog by accessible name, and asserted positively (the tag must look like a version) rather than negatively — a
Not.ToHaveTextalso passes when the element is missing, so it could only fail for the wrong reasons.Three consecutive runs green; full E2E 53/53.