Skip to content

Scope the about-popover assertion to its own dialog #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivanvyd merged 1 commit into from
Jul 30, 2026
Merged

Scope the about-popover assertion to its own dialog #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions tests/Healthie.Tests.E2E/DashboardGroupingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Microsoft.Playwright;
using System.Text.RegularExpressions;

namespace Healthie.Tests.E2E;

Expand Down Expand Up @@ -385,9 +386,15 @@ public async Task Dashboard_LegendAndAbout_OpensBehindTheHeaderIconRatherThanTak

await page.GetByRole(AriaRole.Button, new() { Name = "Legend and about" }).ClickAsync();

await Assertions.Expect(page.Locator(".hpm-popover")).ToBeVisibleAsync();
// The version comes from the assembly; a Razor slip once rendered it as literal text.
await Assertions.Expect(page.Locator(".hpm-popover-head .hpm-tag")).Not.ToHaveTextAsync("v@PackageVersion");
var about = page.GetByRole(AriaRole.Dialog, new() { Name = "Legend and about" });
await Assertions.Expect(about).ToBeVisibleAsync();

// Scoped to this dialog, and asserted positively. ".hpm-popover-head .hpm-tag" matches the
// event log's header too, so it resolved to two elements whenever both were in the DOM --
// which is a strict-mode violation, and why this failed only under load. A negative
// assertion also passes when the element is simply missing; a version-shaped one cannot.
await Assertions.Expect(about.Locator(".hpm-popover-head .hpm-tag"))
.ToHaveTextAsync(new Regex(@"^v\d+\.\d+"));
browser.AssertNoErrors(page);
}

Expand Down