refactor: Remove redundant Console creation in _watch_status() (#46)

The _watch_status() function created its own Console instance when the
module already imports console from remote.utils. This change:

- Removes local watch_console = Console() in _watch_status()
- Uses the shared console instance from utils instead
- Removes now-unused Console import from rich.console
- Updates test to mock console instead of Console

This completes the console centralization refactor - all modules now
use the shared console instance from remote/utils.py.

Co-authored-by: Claude <noreply@anthropic.com>
(cherry picked from commit 7d639db)

progress.md

@@ -381,3 +381,27 @@ This duplication meant any changes to console configuration would need to be mad
 
 **Note:** `remote/instance.py` still imports `Console` from `rich.console` because the `_watch_status` function creates a separate Console instance for its Live display functionality.
 
+---
+
+## 2026-01-18: Remove redundant Console creation in `_watch_status()`
+
+**File:** `remote/instance.py`
+
+**Issue:** The `_watch_status()` function created a new `Console()` instance on line 305:
+```python
+watch_console = Console()
+```
+
+This was redundant because:
+1. The module already imports `console` from `remote.utils` (centralized console instance)
+2. The local `watch_console` duplicated functionality already available
+3. This was noted as an exception in the previous refactor, but there's no reason not to reuse the shared console
+
+**Changes:**
+- Removed the `watch_console = Console()` line from `_watch_status()`
+- Changed `Live(console=watch_console, ...)` to `Live(console=console, ...)`
+- Changed `watch_console.print(...)` to `console.print(...)`
+- Removed the now-unused `from rich.console import Console` import
+
+This completes the console centralization refactor - all modules now use the shared `console` instance from `remote/utils.py`.
+

remote/instance.py

@@ -7,7 +7,6 @@
 
 import typer
 from botocore.exceptions import ClientError, NoCredentialsError
-from rich.console import Console
 from rich.live import Live
 from rich.panel import Panel
 from rich.table import Table
@@ -302,16 +301,14 @@ def _build_status_table(instance_name: str, instance_id: str) -> Panel | str:
 
 def _watch_status(instance_name: str, instance_id: str, interval: int) -> None:
     """Watch instance status with live updates."""
-    watch_console = Console()
-
     try:
-        with Live(console=watch_console, refresh_per_second=1, screen=True) as live:
+        with Live(console=console, refresh_per_second=1, screen=True) as live:
             while True:
                 result = _build_status_table(instance_name, instance_id)
                 live.update(result)
                 time.sleep(interval)
     except KeyboardInterrupt:
-        watch_console.print("\nWatch mode stopped.")
+        console.print("\nWatch mode stopped.")
 
 
 @app.command()

tests/test_instance.py

@@ -442,8 +442,8 @@ def test_should_handle_keyboard_interrupt(self, mocker):
         # Mock _build_status_table to return a simple string
         mocker.patch("remote.instance._build_status_table", return_value="test")
 
-        # Mock Console and Live
-        mocker.patch("remote.instance.Console")
+        # Mock console (imported from utils) and Live
+        mocker.patch("remote.instance.console")
         mock_live = mocker.patch("remote.instance.Live")
         mock_live.return_value.__enter__ = mocker.Mock(return_value=mock_live.return_value)
         mock_live.return_value.__exit__ = mocker.Mock(return_value=False)