Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
c684fc4
feat: Add Pydantic config validation with environment variable support
claude Jan 18, 2026
aab1650
feat: Add built-in watch mode for instance status command
claude Jan 18, 2026
c20aed2
refactor: Remove unused cfg parameter from get_instance_name()
claude Jan 18, 2026
cff9995
fix: Use correct config key ssh_key_path in connect()
claude Jan 18, 2026
157d0a0
docs: Add issue 36 for config validate panel width
ivyleavedtoadflax Jan 18, 2026
e40c8c3
refactor: Remove unnecessary builtins import from instance.py (#18)
ivyleavedtoadflax Jan 18, 2026
e32dcc1
refactor: Remove unused Typer app instance from utils.py
claude Jan 18, 2026
8514550
refactor: Use cached get_sts_client() in get_account_id()
claude Jan 18, 2026
998813e
docs: Add issues 37-38 for pricing improvements
ivyleavedtoadflax Jan 18, 2026
edf1135
fix: Remove hardcoded console width and simplify validate output
claude Jan 18, 2026
1515e21
docs: Add issue 39 for scheduled instance shutdown
ivyleavedtoadflax Jan 18, 2026
48226c4
docs: Update issue 39 to use remote shutdown command
ivyleavedtoadflax Jan 18, 2026
8773ac0
feat: Add region fallback for pricing API (#22)
ivyleavedtoadflax Jan 18, 2026
bd661c1
feat: Add scheduled instance shutdown via SSH
claude Jan 18, 2026
6abf1c7
docs: Add issue 40 for console output consistency
ivyleavedtoadflax Jan 18, 2026
42f6f75
feat: Standardize console output styles for ECS commands
claude Jan 18, 2026
6d01aa6
feat: Add instance cost command to show estimated cost based on uptim…
ivyleavedtoadflax Jan 18, 2026
904d98a
docs: Add issues 41-42 for cost fixes and ls/status clarification
ivyleavedtoadflax Jan 18, 2026
d483cdd
docs: Add testing requirements for issue 41
ivyleavedtoadflax Jan 18, 2026
c814b3d
feat: Integrate cost columns into instance ls with --cost flag (#41)
claude Jan 18, 2026
89444b0
docs: Reopen issue 41 - cost still not displaying
ivyleavedtoadflax Jan 18, 2026
59f489a
feat: Differentiate instance ls and status commands (#42) (#27)
ivyleavedtoadflax Jan 18, 2026
d45b087
refactor: Remove unnecessary enumerate() in get_instance_ids() (#28)
ivyleavedtoadflax Jan 18, 2026
23defd4
refactor: Remove unused drop_nameless parameter from get_instance_info()
claude Jan 18, 2026
abd960b
refactor: Remove deprecated ec2_client backwards compatibility shim
claude Jan 18, 2026
5a9a03e
refactor: Remove deprecated ecs_client backwards compatibility shim
claude Jan 18, 2026
d609bd2
refactor: Remove unused ENV_PREFIX constant from config.py (#32)
ivyleavedtoadflax Jan 18, 2026
9fd5a15
refactor: Rename in_duration parameter to stop_in for consistency (#33)
ivyleavedtoadflax Jan 18, 2026
3074968
docs: Add issue 43 for Rich Panel width fix
ivyleavedtoadflax Jan 18, 2026
f2b1ef5
refactor: Rename type function and parameter to avoid shadowing built…
ivyleavedtoadflax Jan 18, 2026
59e5ba1
refactor: Add missing width=200 to Console initialization in config.py
claude Jan 18, 2026
79b1500
refactor: Remove unused is_instance_stopped() function (#36)
ivyleavedtoadflax Jan 18, 2026
3a8e525
fix: Correct EU region location names in pricing API
ivyleavedtoadflax Jan 18, 2026
eb64967
docs: Update issue 41 with root cause and fix details
ivyleavedtoadflax Jan 18, 2026
b9968ef
docs: Add issue 44 for test API validation
ivyleavedtoadflax Jan 18, 2026
51043d5
refactor: Remove duplicate list_launch_templates() from instance.py
claude Jan 18, 2026
15ec8b7
docs: Add issue 45 for v1.1.0 release preparation
ivyleavedtoadflax Jan 18, 2026
a0ce56c
fix: Set expand=False on all Rich Panels to prevent full-width expansion
claude Jan 18, 2026
553aeb7
test: Add AWS API contract validation tests (#39)
ivyleavedtoadflax Jan 18, 2026
4e357ec
release: Prepare v1.1.0 release (#40)
ivyleavedtoadflax Jan 18, 2026
88143e6
refactor: Remove unused ConfigurationError exception class (#41)
ivyleavedtoadflax Jan 18, 2026
dd0cebb
refactor: Remove unused InvalidInstanceStateError exception class (#42)
ivyleavedtoadflax Jan 18, 2026
66fca37
refactor: Extract _build_ssh_command() helper to reduce duplication
claude Jan 18, 2026
882fb10
refactor: Consolidate datetime imports to module level in instance.py…
ivyleavedtoadflax Jan 18, 2026
1c75cde
refactor: Centralize console initialization in utils.py
claude Jan 18, 2026
443eae3
refactor: Remove redundant Console creation in _watch_status() (#46)
ivyleavedtoadflax Jan 18, 2026
181e266
chore: Add gitleaks to pre-commit hooks for secret detection
ivyleavedtoadflax Jan 18, 2026
d03e4b5
refactor: Remove redundant get_instance_type() call in instance_type()
claude Jan 18, 2026
fb62a5d
refactor: Replace overly broad exception handling in list_launch_temp…
ivyleavedtoadflax Jan 18, 2026
57ccc78
refactor: Remove misleading return type from list_launch_templates() …
ivyleavedtoadflax Jan 18, 2026
1122bcd
refactor: Replace overly broad exception handling in config.py (#50)
ivyleavedtoadflax Jan 18, 2026
d4c79e8
refactor: Replace silent exception handler in list_launch_templates()
claude Jan 18, 2026
944d1ac
refactor: Extract duplicated launch() logic into shared utility funct…
ivyleavedtoadflax Jan 18, 2026
0fd926d
refactor: Add explicit exit codes to typer.Exit() calls in ecs.py
claude Jan 18, 2026
58a4df7
refactor: Standardize docstring formatting in ecs.py
claude Jan 18, 2026
983c829
refactor: Standardize Typer parameter style in status() command (#55)
ivyleavedtoadflax Jan 18, 2026
d7a6ed7
refactor: Remove unused get_instance_pricing_info() function (#56)
ivyleavedtoadflax Jan 18, 2026
9c11aad
refactor: Standardize ConfigParser variable naming in config.py (#57)
ivyleavedtoadflax Jan 18, 2026
1e82ecc
refactor: Remove unused if __name__ == "__main__" blocks
claude Jan 18, 2026
7c6ad98
refactor: Remove unused return value from write_config() function
claude Jan 18, 2026
aae4c54
refactor: Remove unused get_snapshot_status() function
claude Jan 18, 2026
8162ea2
refactor: Remove unused validate_snapshot_id() function
claude Jan 18, 2026
4cefa73
refactor: Move Terraform comment to be adjacent to its code
claude Jan 18, 2026
9628c2c
refactor: Use config_manager.remove_value() in unset_value command (#63)
ivyleavedtoadflax Jan 18, 2026
60fc458
refactor: Simplify config path assignment with ternary operators
claude Jan 18, 2026
ac4586b
refactor: Remove unused get_monthly_estimate() function and HOURS_PER…
ivyleavedtoadflax Jan 18, 2026
3645737
refactor: Extract duplicate exception handling to helper method in Co…
ivyleavedtoadflax Jan 18, 2026
c842185
refactor: Fix inconsistent filtering in get_instance_ids()
claude Jan 18, 2026
252f035
refactor: Fix get_value CLI command to use ConfigManager consistently…
ivyleavedtoadflax Jan 18, 2026
317773d
refactor: Extract hardcoded time constants in instance.py (#69)
ivyleavedtoadflax Jan 18, 2026
6240778
refactor: Add MINUTES_PER_HOUR constant for semantic correctness
claude Jan 18, 2026
c840673
refactor: Extract SSH readiness sleep to constant (#71)
ivyleavedtoadflax Jan 18, 2026
af5b261
refactor: Extract type change polling magic numbers to constants
claude Jan 18, 2026
1f4c92d
docs: Add issue 46 for connect stopped instance behavior (GitHub #73)
ivyleavedtoadflax Jan 18, 2026
c703a78
feat: Add --start and --no-start flags to connect command (GitHub #73)
claude Jan 18, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: Remove unused cfg parameter from get_instance_name()
- Remove unused `cfg: ConfigParser | None = None` parameter from get_instance_name()
- Remove corresponding docstring documentation for the parameter
- Remove now-unused `from configparser import ConfigParser` import

The parameter was marked as "for backward compatibility" but was never used
in the function body (it always used config_manager instead), and none of
the 8 call sites passed any arguments.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
(cherry picked from commit 24a886a)
  • Loading branch information
claude authored and ivyleavedtoadflax committed Jan 18, 2026
commit c20aed2b2654827f94514767719b1fe663c4eef7
14 changes: 14 additions & 0 deletions progress.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Progress Log

## 2026-01-18: Remove unused `cfg` parameter from `get_instance_name()`

**File:** `remote/utils.py`

**Issue:** The `get_instance_name()` function had an unused parameter `cfg: ConfigParser | None = None`. The docstring mentioned it was for "backward compatibility" but:
1. The parameter was never used inside the function
2. All callers (8 call sites across instance.py, ami.py, snapshot.py, volume.py) called the function without arguments

**Changes:**
- Removed the unused `cfg` parameter from the function signature
- Removed the corresponding parameter documentation from the docstring
- Removed the now-unused `from configparser import ConfigParser` import
6 changes: 1 addition & 5 deletions remote/utils.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from configparser import ConfigParser
from datetime import datetime, timezone
from functools import lru_cache
from typing import TYPE_CHECKING, Any, cast
Expand Down Expand Up @@ -281,12 +280,9 @@ def get_instance_dns(instance_id: str) -> str:
raise AWSServiceError("EC2", "describe_instances", error_code, error_message)


def get_instance_name(cfg: ConfigParser | None = None) -> str:
def get_instance_name() -> str:
"""Returns the name of the instance as defined in the config file.

Args:
cfg: Legacy config parser (for backward compatibility)

Returns:
str: Instance name if found

Expand Down