feat(v0.5): add error banner and error state UI#3
Merged
Conversation
- Add ErrorBanner component: dismissable inline banner for transient errors, with optional Retry button. Supports dataLoadFailed, operationFailed, networkError, and validationFailed kinds. - Add ErrorState component: full-screen parchment-card error UI shown when museum data fails to load, with a Try Again button. - Wire both into ACCanvas: data fetch now sets loadError state on failure (distinguishes network vs. parse errors); ErrorState replaces the blank screen; ErrorBanner sits below MuseumHeader for future transient errors; retry re-runs the fetch. - Mirrors iOS ErrorBanner/ErrorState pattern from AnimalCrossingGCN-Tracker. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ErrorBanner component: New dismissible error banner with support for multiple error types (
dataLoadFailed,networkError,operationFailed,validationFailed). Includes optional retry button and recovery suggestions.ErrorState component: New full-page error state UI for critical load failures. Displays appropriate messaging and icons based on error type with retry functionality.
ACCanvas integration: Enhanced with error handling:
loadMuseumData()function for reusabilityErrorStateduring critical failures andErrorBannerfor recoverable errorsVisual Design