v0.9 Phase 3: Settings page (About + Danger zone)#66
Merged
Conversation
About + Danger zone sections per locked decisions #3 and #7. No Appearance section (Meadow-only per #2). - SettingsPage: About (version, source, live storage summary, credits) and Danger zone (reset donations, reset everything) with native confirm() guards. Esc and close button navigate back to active town home. - SettingsRoute wrapper renders Sidebar + SettingsPage so the sidebar stays in place at /settings. - Store: resetActiveTownDonations() + resetAll() (also clears ac-curator-search-history from localStorage). - /settings route added in App.tsx; Sidebar Settings button no longer carries the Phase 2 "coming soon" tooltip. - Styles in index.css mirror docs/design-handoffs/v0.9.2_curator/ addons-styles.css with the Curator-codename strings dropped. Build, lint, and 59 unit tests pass.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 3 of v0.9.0-beta per
docs/v0.9-plan.md§ Phase 3. Adds the/settingsroute with About and Danger zone sections. No Appearance section per locked decision #3 — Meadow is the only theme in v0.9.What changed
src/components/SettingsPage.tsx— full-page Settings UI: About (version fromVITE_APP_VERSION, GitHub source link, live storage summary derived from store, credits) + Danger zone with twoconfirm()-guarded actions ("Reset donations for active town" ghost, "Reset everything" solid red). Esc + close button navigate back to active town home (or/if no town).src/components/SettingsRoute.tsx— route wrapper that mountsSidebar+SettingsPageso the sidebar (active town card, nav, footer) stays in place at/settings.src/App.tsx— adds<Route path="/settings" element={<SettingsRoute />} />.src/lib/store.ts— addsresetActiveTownDonations()andresetAll().resetAll()also clearsac-curator-search-historyfrom localStorage (forward-compatible with the Phase 8 search history key).src/index.css— Settings page styles ported fromdocs/design-handoffs/v0.9.2_curator/addons-styles.css(.ac-settings*,.ac-about-list,.ac-settings-danger,.ac-danger-*,ac-fade-upkeyframe). Responsive collapse at ≤700px (title 56→40px, About list single-column, Danger rows stack with full-width buttons).src/components/Sidebar.tsx— drops the Phase 2 "coming in Phase 3" tooltip on the Settings link.Decisions
/settings) rather than nested under/town/:townId/settings. Settings is an app property, not a town property — and a user mid-Reset everythingwouldn't have an active town to nest under.Reset everythingclearsac-curator-search-historydefensively even though that key isn't written until Phase 8. Safer than coming back later. The legacy in-memoryrecentSearchesfromuseSearchis naturally cleared by component unmount; nothing to wipe.window.confirm()for both danger actions per locked decision feat(home): add home screen with seasonal availability and progress overview #7 — a styled confirm dialog is a v1.0 polish item.Status
npm run build— pass (tsc + vite, no TS errors)npm test— 59 tests passnpm run lint— pass (notypecheckscript in this repo;tsc --noEmitruns as part ofbuild)Test plan
/settingsfrom sidebar footer link — page renders with sidebar intacttownCountandtotalDonations/, search-history key removed from localStorage/town/:id/home)Out of scope (per plan)
TownManager.