Repair the type annotations in the TokenViewBase class.#880
Merged
vgrozdanic merged 4 commits intojazzband:masterfrom Mar 3, 2025
Merged
Repair the type annotations in the TokenViewBase class.#880vgrozdanic merged 4 commits intojazzband:masterfrom
vgrozdanic merged 4 commits intojazzband:masterfrom
Conversation
for more information, see https://pre-commit.ci
…re. So we don't need the Type from typing.
vgrozdanic
reviewed
Mar 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When extending the
TokenViewBaseclass in order to override theserializer_classproperty, the type of the property is already established as NoneType, causing type check errors.This PR explicitly annotates
serializer_classto beOptional[Type[Serializer]], allowing for the defaultNoneand also any other class that is a child ofSerializer.Note also that the type of the return of
get_serializer_class()was erroneouslySerializer(an instance ofSerializer), when it should beType[Serializer](a class who's type includesSerializer).EDIT: Turned out BaseSerializer was the correct type, not Serializer.