Skip to content

Repair the type annotations in the TokenViewBase class. #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vgrozdanic merged 4 commits into from
Mar 3, 2025
Merged

Repair the type annotations in the TokenViewBase class. #880

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c54b6da
Repair the type annotations in the TokenViewBase class.
triplepoint Mar 2, 2025
6d8add8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 2, 2025
82096e0
Ah, python3.9 did support parameterizing the 'type' type. I wasn't s…
triplepoint Mar 2, 2025
cfb37bb
The abstract type is BaseSerializer, not Serializer
triplepoint Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions rest_framework_simplejwt/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
from typing import Optional

from django.utils.module_loading import import_string
from rest_framework import generics, status
from rest_framework.request import Request
from rest_framework.response import Response
from rest_framework.serializers import Serializer
from rest_framework.serializers import BaseSerializer

from .authentication import AUTH_HEADER_TYPES
from .exceptions import InvalidToken, TokenError
Expand All @@ -13,12 +15,12 @@ class TokenViewBase(generics.GenericAPIView):
permission_classes = ()
authentication_classes = ()

serializer_class = None
serializer_class: Optional[type[BaseSerializer]] = None
_serializer_class = ""

www_authenticate_realm = "api"

def get_serializer_class(self) -> Serializer:
def get_serializer_class(self) -> type[BaseSerializer]:
"""
If serializer_class is set, use it directly. Otherwise get the class from settings.
"""
Expand Down
Loading