This repository was archived by the owner on Apr 15, 2020. It is now read-only.
Update to Swift 5#131
Merged
jessesquires merged 7 commits intoSep 23, 2019
Merged
Conversation
Owner
|
Thanks so much @kevnm67 ! Super sorry for the delay here. I'll get to this tomorrow. 😄 |
[Fixed] - Travis build failure due to incorrect simulator for xcode 10.2 image.
- Updated gemfile to use latest cocoapods [fixing pod lint error](CocoaPods/CocoaPods#8875).
Owner
|
Reverted some of the unrelated changes that I'll take care of on |
Collaborator
Author
|
@jessesquires I would have happily broke out the CI updates 😆 Only reason I added them was the need to fix Travis build failures. I actually have an Xcode 11 PR waiting 😉
|
Owner
|
@kevnm67 oops! Sorry 😅 I should have asked first |
Owner
|
the travis config was also set to Xcode10.2, so a bit out-dated. merged into a new branch |
Collaborator
Author
|
@jessesquires All good. Im all for the divide and conquer approach 😉 |
jessesquires
added a commit
that referenced
this pull request
Sep 24, 2019
* Update to Swift 5 (#131) * Xcode 11 update, settings/config * Update @unknown default: enum cases * [SwiftLint] update 0.35, add new rules * [travis ci] update for xcode 11, add ui tests * Update README * [Gems] Update cocoapods 1.7.5, danger 6.0 * update podspec * update CHANGELOG * Fix, cleanup, refactor UI Tests * bump version to 8.1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
This fixes issue
Closes issue #117
What's in this pull request?